* [PATCH v2] OMAP: ctrl: Fix CONTROL_DSIPHY register fields
@ 2011-07-27 10:33 Archit Taneja
2011-07-27 10:27 ` Santosh Shilimkar
2011-08-01 22:21 ` Paul Walmsley
0 siblings, 2 replies; 3+ messages in thread
From: Archit Taneja @ 2011-07-27 10:33 UTC (permalink / raw)
To: tony, b-cousson, santosh.shilimkar, paul
Cc: linux, linux-omap, linux-arm-kernel, Archit Taneja
Fix the shift and mask macros for DSIx_PPID fields in CONTROL_DSIPHY. The
OMAP4430 Public TRM vV has these fields mentioned correctly.
Signed-off-by: Archit Taneja <archit@ti.com>
Acked-by: Benoit Cousson <b-cousson@ti.com>
---
v2:
- Improve commit description.
- Define fields in decreasing order of the field's end bit.
.../include/mach/ctrl_module_pad_core_44xx.h | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h b/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
index c88420d..1e2d332 100644
--- a/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
+++ b/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
@@ -941,10 +941,10 @@
#define OMAP4_DSI2_LANEENABLE_MASK (0x7 << 29)
#define OMAP4_DSI1_LANEENABLE_SHIFT 24
#define OMAP4_DSI1_LANEENABLE_MASK (0x1f << 24)
-#define OMAP4_DSI1_PIPD_SHIFT 19
-#define OMAP4_DSI1_PIPD_MASK (0x1f << 19)
-#define OMAP4_DSI2_PIPD_SHIFT 14
-#define OMAP4_DSI2_PIPD_MASK (0x1f << 14)
+#define OMAP4_DSI2_PIPD_SHIFT 19
+#define OMAP4_DSI2_PIPD_MASK (0x1f << 19)
+#define OMAP4_DSI1_PIPD_SHIFT 14
+#define OMAP4_DSI1_PIPD_MASK (0x1f << 14)
/* CONTROL_MCBSPLP */
#define OMAP4_ALBCTRLRX_FSX_SHIFT 31
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] OMAP: ctrl: Fix CONTROL_DSIPHY register fields
2011-07-27 10:33 [PATCH v2] OMAP: ctrl: Fix CONTROL_DSIPHY register fields Archit Taneja
@ 2011-07-27 10:27 ` Santosh Shilimkar
2011-08-01 22:21 ` Paul Walmsley
1 sibling, 0 replies; 3+ messages in thread
From: Santosh Shilimkar @ 2011-07-27 10:27 UTC (permalink / raw)
To: Archit Taneja; +Cc: tony, b-cousson, paul, linux, linux-omap, linux-arm-kernel
On 7/27/2011 4:03 PM, Archit Taneja wrote:
> Fix the shift and mask macros for DSIx_PPID fields in CONTROL_DSIPHY. The
> OMAP4430 Public TRM vV has these fields mentioned correctly.
>
> Signed-off-by: Archit Taneja<archit@ti.com>
> Acked-by: Benoit Cousson<b-cousson@ti.com>
> ---
> v2:
> - Improve commit description.
> - Define fields in decreasing order of the field's end bit.
>
Thanks for the update.
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> .../include/mach/ctrl_module_pad_core_44xx.h | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h b/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
> index c88420d..1e2d332 100644
> --- a/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
> +++ b/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
> @@ -941,10 +941,10 @@
> #define OMAP4_DSI2_LANEENABLE_MASK (0x7<< 29)
> #define OMAP4_DSI1_LANEENABLE_SHIFT 24
> #define OMAP4_DSI1_LANEENABLE_MASK (0x1f<< 24)
> -#define OMAP4_DSI1_PIPD_SHIFT 19
> -#define OMAP4_DSI1_PIPD_MASK (0x1f<< 19)
> -#define OMAP4_DSI2_PIPD_SHIFT 14
> -#define OMAP4_DSI2_PIPD_MASK (0x1f<< 14)
> +#define OMAP4_DSI2_PIPD_SHIFT 19
> +#define OMAP4_DSI2_PIPD_MASK (0x1f<< 19)
> +#define OMAP4_DSI1_PIPD_SHIFT 14
> +#define OMAP4_DSI1_PIPD_MASK (0x1f<< 14)
>
> /* CONTROL_MCBSPLP */
> #define OMAP4_ALBCTRLRX_FSX_SHIFT 31
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] OMAP: ctrl: Fix CONTROL_DSIPHY register fields
2011-07-27 10:33 [PATCH v2] OMAP: ctrl: Fix CONTROL_DSIPHY register fields Archit Taneja
2011-07-27 10:27 ` Santosh Shilimkar
@ 2011-08-01 22:21 ` Paul Walmsley
1 sibling, 0 replies; 3+ messages in thread
From: Paul Walmsley @ 2011-08-01 22:21 UTC (permalink / raw)
To: Archit Taneja
Cc: tony, b-cousson, santosh.shilimkar, linux, linux-omap,
linux-arm-kernel
On Wed, 27 Jul 2011, Archit Taneja wrote:
> Fix the shift and mask macros for DSIx_PPID fields in CONTROL_DSIPHY. The
> OMAP4430 Public TRM vV has these fields mentioned correctly.
Thanks, queued for 3.2 in the scm_fixes_3.2 branch of
git://git.pwsan.com/linux-2.6
Also added Santosh's ack.
- Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-01 22:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-27 10:33 [PATCH v2] OMAP: ctrl: Fix CONTROL_DSIPHY register fields Archit Taneja
2011-07-27 10:27 ` Santosh Shilimkar
2011-08-01 22:21 ` Paul Walmsley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).