From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH 5/5] OMAP4: DSS2: VIDEO3 pipeline support Date: Fri, 5 Aug 2011 14:51:07 +0530 Message-ID: <4E3BB603.7010908@ti.com> References: <1312530172-24095-1-git-send-email-archit@ti.com> <1312530172-24095-6-git-send-email-archit@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:52377 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756285Ab1HEJM2 (ORCPT ); Fri, 5 Aug 2011 05:12:28 -0400 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id p759CPYd005121 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 5 Aug 2011 04:12:27 -0500 In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Semwal, Sumit" Cc: "Valkeinen, Tomi" , "linux-omap@vger.kernel.org" Hi, On Friday 05 August 2011 02:13 PM, Semwal, Sumit wrote: >> On Fri, Aug 5, 2011 at 8:42 AM, Archit Taneja wrote: >>> >>> Add support for VIDEO3 pipeline on OMAP4: >>> - Add VIDEO3 pipeline information in dss_features and omapdss.h >>> - Add VIDEO3 pipeline register coefficients in dispc.h >>> - Create a new overlay structure corresponding to VIDEO3. >>> >>> Signed-off-by: Archit Taneja >>> --- > >>> - u32 fifo_size[3]; >>> + u32 fifo_size[MAX_DSS_OVERLAYS]; >> > Do you think it makes some sense in splitting the 'generalisation' > like this that you've done in the patch from the xxx_VIDEO3 changes? Yes, I could make a small patch which replaces "3" with MAX_DSS_OVERLAYS, and the patch which introduces VIDEO3 pipe will increase the macro value from 3 to 4. Thanks, Archit > It might make it look a little cleaner; otherwise the changes look > good to me; feel free to add my reviewed-by. [and to other patches in > this series]. >>> > >