Re: [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver

[Rajendra Nayak <rnayak@ti.com>]

On 8/11/2011 7:42 PM, Felipe Balbi wrote:
> Hi,
>
> On Thu, Aug 11, 2011 at 06:30:04PM +0530, J, KEERTHY wrote:
>>>>>> >  >>  >>  diff --git a/drivers/hwmon/omap_temp_sensor.c b/drivers/hwmon/omap_temp_sensor.c
>>>>>> >  >>  >>  new file mode 100644
>>>>>> >  >>  >>  index 0000000..15e2559
>>>>>> >  >>  >>  --- /dev/null
>>>>>> >  >>  >>  +++ b/drivers/hwmon/omap_temp_sensor.c
>>>>>> >  >>  >>  @@ -0,0 +1,950 @@
>>>>>> >  >>  >>  +/*
>>>>>> >  >>  >>  + * OMAP4 Temperature sensor driver file
>>>>>> >  >>  >>  + *
>>>>>> >  >>  >>  + * Copyright (C) 2011 Texas Instruments Incorporated -http://www.ti.com/
>>>>>> >  >>  >>  + * Author: J Keerthy<j-keerthy@ti.com>
>>>>>> >  >>  >>  + * Author: Moiz Sonasath<m-sonasath@ti.com>
>>>>>> >  >>  >>  + *
>>>>>> >  >>  >>  + * This program is free software; you can redistribute it and/or
>>>>>> >  >>  >>  + * modify it under the terms of the GNU General Public License
>>>>>> >  >>  >>  + * version 2 as published by the Free Software Foundation.
>>>>>> >  >>  >>  + *
>>>>>> >  >>  >>  + * This program is distributed in the hope that it will be useful, but
>>>>>> >  >>  >>  + * WITHOUT ANY WARRANTY; without even the implied warranty of
>>>>>> >  >>  >>  + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>>>>>> >  >>  >>  + * General Public License for more details.
>>>>>> >  >>  >>  + *
>>>>>> >  >>  >>  + * You should have received a copy of the GNU General Public License
>>>>>> >  >>  >>  + * along with this program; if not, write to the Free Software
>>>>>> >  >>  >>  + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
>>>>>> >  >>  >>  + * 02110-1301 USA
>>>>>> >  >>  >>  + *
>>>>>> >  >>  >>  + */
>>>>>> >  >>  >>  +
>>>>>> >  >>  >>  +#include<linux/interrupt.h>
>>>>>> >  >>  >>  +#include<linux/clk.h>
>>>>> >  >>  >
>>>>> >  >>  >  why ??
>>>> >  >>
>>>> >  >>  Clock rate setting functions.
>>> >  >
>>> >  >  you shouldn't need in drivers.
>> >
>> >  It is a one time setting of the rate so keeping it in drivers.
> you need some other way to handle this. Why do you need to manually set
> the rate rather than having hwmod handle this for you ?

Because hwmod has not idea about what rate a device needs to operate
in any point.