Re: OMAP3 kernels fail to build

Russell King - ARM Linux
2011-08-08T11:30:39Z

On Mon, Aug 08, 2011 at 04:39:32PM +0530, Santosh wrote:
> + Felipe,
>
> On Monday 08 August 2011 04:30 PM, Russell King - ARM Linux wrote:
>> With CONFIG_ARCH_OMAP3=y and CONFIG_ARCH_OMAP4=n, I'm getting this:
>>
>> arch/arm/mach-omap2/built-in.o:(.data+0xf99c): undefined reference to `omap4430_phy_init'
>> arch/arm/mach-omap2/built-in.o:(.data+0xf9a0): undefined reference to `omap4430_phy_exit'
>> arch/arm/mach-omap2/built-in.o:(.data+0xf9a4): undefined reference to `omap4430_phy_power'
>> arch/arm/mach-omap2/built-in.o:(.data+0xf9a8): undefined reference to `omap4430_phy_set_clk'
>> arch/arm/mach-omap2/built-in.o:(.data+0xf9ac): undefined reference to `omap4430_phy_suspend'
>>
> I thought below patch was suppose to fix it.
> https://patchwork.kernel.org/patch/963462/

So, the problem has been known about for around a month. Yet the broken
patch still went upstream.

vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
IF IT IS KNOWN THAT A PATCH IS BROKEN IT MUST NOT BE SUBMITTED TO MAINLINE
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

We've seen other instances of that during this merge window, and Linus
has responded thusly to these incidents:

http://lkml.org/lkml/2011/8/4/390

On Thu, Aug 4, 2011 at 2:52 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> The last three commits in the idle tree that you took from Len were in
> linux-next until April 15 and then disappeared until yesterday.  The last
> of these was broken back then and has been committed exactly the same now
> and still breaks arm and sh.
>
> I have reverted that commit from your tree for today ...

Len, this is *exactly* why I com plained about the git trees you pushed to me.

And then I pulled anyway, because you and others convinced me things
had been in -next despite the commit dates being odd.

Let's just say that I'm really *really* disappointed. And dammit, you
need to fix your workflow. Don't add random commits late. If you're
offline, you're offline, and you send the old tested tree, not some
last-minute crap.

Next time I find reason to complain, I just won't pull. In fact, I'm
seriously considering a rather draconian measure for next merge
window: I'll fetch the -next tree when I open the merge window, and if
I get anything but trivial fixes that don't show up in that "next tree
at the point of merge window open", I'll just ignore that pull
request. Because clearly people are just not being careful enough.

It's really *very* annoying to hear that a bug has been known about
for weeks (or months) and just not fixed, and then shows up again THE
SAME DAY that the pull request is sent to me.

Linus