From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Subject: Re: [PATCH] OMAP: clockdomain: Wait for powerdomain to be ON when using clockdomain force wakeup Date: Wed, 17 Aug 2011 10:41:44 +0530 Message-ID: <4E4B4D90.9040103@ti.com> References: <1310527588-13022-1-git-send-email-santosh.shilimkar@ti.com> <1310527588-13022-2-git-send-email-santosh.shilimkar@ti.com> <4E214267.2090700@ti.com> <4E43E23C.2080207@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from na3sys009aog103.obsmtp.com ([74.125.149.71]:35155 "EHLO na3sys009aog103.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751978Ab1HQFMA (ORCPT ); Wed, 17 Aug 2011 01:12:00 -0400 Received: by mail-yw0-f41.google.com with SMTP id 13so500637ywm.28 for ; Tue, 16 Aug 2011 22:11:59 -0700 (PDT) In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: Rajendra Nayak , linux-omap@vger.kernel.org, Tero Kristo , linux-arm-kernel@lists.infradead.org, khilman@ti.com, p-titiano@ti.com, b-cousson@ti.com On Wednesday 17 August 2011 07:17 AM, Paul Walmsley wrote: > > Hi everyone > > I've updated this patch per my earlier comments and also to apply. > Please let me know if you have any issues with it ASAP. > > > - Paul > > From: Santosh Shilimkar > Date: Sat, 13 Aug 2011 08:56:28 +0530 > Subject: [PATCH] [PATCH] OMAP: clockdomain: Wait for powerdomain to be ON > when using clockdomain force wakeup > > While using clockdomain force wakeup method, not waiting for powerdomain > to be effectively ON may end up locking the clockdomain FSM until a > next wakeup event occurs. > > One such issue was seen on OMAP4430, where L4_PER was periodically > getting stuck in in-transition state when transitioning from from OSWR to ON. > > This issue was reported and investigated by Patrick Titiano > > Signed-off-by: Santosh Shilimkar > Signed-off-by: Rajendra Nayak > Reported-by: Patrick Titiano > Cc: Kevin Hilman > Cc: Benoit Cousson > Cc: Paul Walmsley > [paul@pwsan.com: updated to apply; added transition wait on clkdm_deny_idle(); > remove two superfluous pwrdm_wait_transition() calls] > Signed-off-by: Paul Walmsley > --- Thanks Paul. Patch looks good to me. Regards Santosh