From: Santosh <santosh.shilimkar@ti.com>
To: Tarun Kanti DebBarma <tarun.kanti@ti.com>
Cc: linux-omap@vger.kernel.org, khilman@ti.com, tony@atomide.com,
linux-arm-kernel@lists.infradead.org, Charulatha V <charu@ti.com>
Subject: Re: [PATCH v5 11/22] gpio/omap: remove hardcoded offsets in ctxt save/restore
Date: Tue, 23 Aug 2011 18:42:46 +0530 [thread overview]
Message-ID: <4E53A74E.4030002@ti.com> (raw)
In-Reply-To: <1312455893-14922-12-git-send-email-tarun.kanti@ti.com>
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote:
> It is not required to use hard-coded offsets any more in context save and
> restore functions and instead use the generic offsets which have been correctly
> initialized during device registration.
>
> Signed-off-by: Tarun Kanti DebBarma<tarun.kanti@ti.com>
> Signed-off-by: Charulatha V<charu@ti.com>
> ---
$SUB
/s /ctx /context please
> arch/arm/mach-omap2/gpio.c | 2 +
> arch/arm/plat-omap/include/plat/gpio.h | 1 +
> drivers/gpio/gpio-omap.c | 41 ++++++++++++++-----------------
> 3 files changed, 22 insertions(+), 22 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/gpio.c b/arch/arm/mach-omap2/gpio.c
> index 8745c3a..0ee9a55 100644
> --- a/arch/arm/mach-omap2/gpio.c
> +++ b/arch/arm/mach-omap2/gpio.c
> @@ -103,6 +103,7 @@ static int omap2_gpio_dev_init(struct omap_hwmod *oh, void *unused)
> pdata->regs->irqstatus = OMAP24XX_GPIO_IRQSTATUS1;
> pdata->regs->irqstatus2 = OMAP24XX_GPIO_IRQSTATUS2;
> pdata->regs->irqenable = OMAP24XX_GPIO_IRQENABLE1;
> + pdata->regs->irqenable2 = OMAP24XX_GPIO_IRQENABLE2;
> pdata->regs->set_irqenable = OMAP24XX_GPIO_SETIRQENABLE1;
> pdata->regs->clr_irqenable = OMAP24XX_GPIO_CLEARIRQENABLE1;
> pdata->regs->debounce = OMAP24XX_GPIO_DEBOUNCE_VAL;
> @@ -125,6 +126,7 @@ static int omap2_gpio_dev_init(struct omap_hwmod *oh, void *unused)
> pdata->regs->irqstatus = OMAP4_GPIO_IRQSTATUS0;
> pdata->regs->irqstatus2 = OMAP4_GPIO_IRQSTATUS1;
> pdata->regs->irqenable = OMAP4_GPIO_IRQSTATUSSET0;
> + pdata->regs->irqenable2 = OMAP4_GPIO_IRQSTATUSSET1;
> pdata->regs->set_irqenable = OMAP4_GPIO_IRQSTATUSSET0;
> pdata->regs->clr_irqenable = OMAP4_GPIO_IRQSTATUSCLR0;
> pdata->regs->debounce = OMAP4_GPIO_DEBOUNCINGTIME;
> diff --git a/arch/arm/plat-omap/include/plat/gpio.h b/arch/arm/plat-omap/include/plat/gpio.h
> index 7d12fe8..0ad4f49 100644
> --- a/arch/arm/plat-omap/include/plat/gpio.h
> +++ b/arch/arm/plat-omap/include/plat/gpio.h
> @@ -184,6 +184,7 @@ struct omap_gpio_reg_offs {
> u16 irqstatus;
> u16 irqstatus2;
> u16 irqenable;
> + u16 irqenable2;
> u16 set_irqenable;
> u16 clr_irqenable;
> u16 debounce;
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index be561be..e7c9fe5 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1348,45 +1348,42 @@ void omap2_gpio_resume_after_idle(void)
> static void omap_gpio_save_context(struct gpio_bank *bank)
> {
> bank->context.irqenable1 =
> - __raw_readl(bank->base + OMAP24XX_GPIO_IRQENABLE1);
> + __raw_readl(bank->base + bank->regs->irqenable);
> bank->context.irqenable2 =
> - __raw_readl(bank->base + OMAP24XX_GPIO_IRQENABLE2);
> + __raw_readl(bank->base + bank->regs->irqenable2);
> bank->context.wake_en =
> - __raw_readl(bank->base + OMAP24XX_GPIO_WAKE_EN);
> - bank->context.ctrl = __raw_readl(bank->base + OMAP24XX_GPIO_CTRL);
> - bank->context.oe = __raw_readl(bank->base + OMAP24XX_GPIO_OE);
> + __raw_readl(bank->base + bank->regs->wkup_status);
Not related to this patch but saving the status register just useless.
You should rather save/restore 'wkup_set' register.
Can you please fix this in relevant patch. O.w this patch looks ok to
me.
Regards
Santosh
next prev parent reply other threads:[~2011-08-23 13:12 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 11:04 [PATCH v5 00/22] gpio/omap: driver cleanup and fixes Tarun Kanti DebBarma
2011-08-04 11:04 ` [PATCH v5 01/22] gpio/omap: remove dependency on gpio_bank_count Tarun Kanti DebBarma
2011-08-23 12:35 ` Santosh
2011-08-29 12:18 ` DebBarma, Tarun Kanti
2011-08-04 11:04 ` [PATCH v5 02/22] gpio/omap: use flag to identify wakeup domain Tarun Kanti DebBarma
2011-08-23 12:41 ` Santosh
2011-08-04 11:04 ` [PATCH v5 03/22] gpio/omap: make gpio_context part of gpio_bank structure Tarun Kanti DebBarma
2011-08-23 12:45 ` Santosh
2011-08-25 20:23 ` Kevin Hilman
2011-08-26 3:57 ` DebBarma, Tarun Kanti
2011-08-26 14:11 ` Santosh
2011-08-04 11:04 ` [PATCH v5 04/22] gpio/omap: fix pwrdm_post_transition call sequence Tarun Kanti DebBarma
2011-08-23 12:47 ` Santosh
2011-08-04 11:04 ` [PATCH v5 05/22] gpio/omap: handle save/restore ctx in GPIO driver Tarun Kanti DebBarma
2011-08-23 12:53 ` Santosh
2011-08-23 14:47 ` Santosh
2011-08-04 11:04 ` [PATCH v5 06/22] gpio/omap: make non-wakeup GPIO part of pdata Tarun Kanti DebBarma
2011-08-23 12:54 ` Santosh
2011-08-04 11:04 ` [PATCH v5 07/22] gpio/omap: avoid cpu checks during module ena/disable Tarun Kanti DebBarma
2011-08-23 12:57 ` Santosh
2011-08-04 11:04 ` [PATCH v5 08/22] gpio/omap: further cleanup using wakeup_status register Tarun Kanti DebBarma
2011-08-23 13:02 ` Santosh
2011-08-04 11:04 ` [PATCH v5 09/22] gpio/omap: cleanup omap1 related macros Tarun Kanti DebBarma
2011-08-23 13:04 ` Santosh
2011-08-04 11:04 ` [PATCH v5 10/22] gpio/omap: use level/edge detect reg offsets Tarun Kanti DebBarma
2011-08-23 13:08 ` Santosh
2011-08-04 11:04 ` [PATCH v5 11/22] gpio/omap: remove hardcoded offsets in ctxt save/restore Tarun Kanti DebBarma
2011-08-23 13:12 ` Santosh [this message]
2011-08-04 11:04 ` [PATCH v5 12/22] gpio/omap: cleanup set_gpio_triggering function Tarun Kanti DebBarma
2011-08-23 13:21 ` Santosh
2011-08-04 11:04 ` [PATCH v5 13/22] gpio/omap: cleanup omap_gpio_mod_init function Tarun Kanti DebBarma
2011-08-23 13:26 ` Santosh
2011-08-04 11:04 ` [PATCH v5 14/22] gpio/omap: use pinctrl offset instead of macro Tarun Kanti DebBarma
2011-08-23 13:27 ` Santosh
2011-08-04 11:04 ` [PATCH v5 15/22] gpio/omap: use readl in irq_handler for all access Tarun Kanti DebBarma
2011-08-23 14:25 ` Santosh
2011-08-04 11:04 ` [PATCH v5 16/22] gpio/omap: remove bank->method & METHOD_* macros Tarun Kanti DebBarma
2011-08-23 14:27 ` Santosh
2011-08-04 11:04 ` [PATCH v5 17/22] gpio/omap: fix bankwidth for OMAP7xx MPUIO Tarun Kanti DebBarma
2011-08-23 14:28 ` Santosh
2011-08-04 11:04 ` [PATCH v5 18/22] gpio/omap: use pm-runtime framework Tarun Kanti DebBarma
2011-08-23 14:34 ` Santosh
2011-08-24 4:02 ` Rajendra Nayak
2011-08-24 6:19 ` Santosh
2011-08-04 11:04 ` [PATCH v5 19/22] gpio/omap: optimize suspend and resume functions Tarun Kanti DebBarma
2011-08-23 14:35 ` Santosh
2011-08-04 11:04 ` [PATCH v5 20/22] gpio/omap: cleanup prepare_for_idle and resume_after_idle Tarun Kanti DebBarma
2011-08-23 14:40 ` Santosh
2011-08-04 11:04 ` [PATCH v5 21/22] gpio/omap: skip operations in runtime callbacks Tarun Kanti DebBarma
2011-08-23 14:41 ` Santosh
2011-08-04 11:04 ` [PATCH v5 22/22] gpio/omap: remove omap_gpio_save_context overhead Tarun Kanti DebBarma
2011-08-23 14:42 ` Santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E53A74E.4030002@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=charu@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tarun.kanti@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox