From mboxrd@z Thu Jan  1 00:00:00 1970
From: Santosh <santosh.shilimkar@ti.com>
Subject: Re: [PATCH v5 03/22] gpio/omap: make gpio_context part of gpio_bank
 structure
Date: Fri, 26 Aug 2011 19:41:18 +0530
Message-ID: <4E57A986.5030800@ti.com>
References: <1312455893-14922-1-git-send-email-tarun.kanti@ti.com>	<1312455893-14922-4-git-send-email-tarun.kanti@ti.com>	<4E53A0EE.5000703@ti.com> <87sjop5jfq.fsf@ti.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-omap-owner@vger.kernel.org>
Received: from na3sys009aog110.obsmtp.com ([74.125.149.203]:46160 "EHLO
	na3sys009aog110.obsmtp.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1755130Ab1HZOL1 (ORCPT
	<rfc822;linux-omap@vger.kernel.org>);
	Fri, 26 Aug 2011 10:11:27 -0400
Received: by mail-gx0-f181.google.com with SMTP id 9so3295301gxk.26
        for <linux-omap@vger.kernel.org>; Fri, 26 Aug 2011 07:11:26 -0700 (PDT)
In-Reply-To: <87sjop5jfq.fsf@ti.com>
Sender: linux-omap-owner@vger.kernel.org
List-Id: linux-omap@vger.kernel.org
To: Kevin Hilman <khilman@ti.com>
Cc: Tarun Kanti DebBarma <tarun.kanti@ti.com>, linux-omap@vger.kernel.org, tony@atomide.com, linux-arm-kernel@lists.infradead.org, Charulatha V <charu@ti.com>

On Friday 26 August 2011 01:53 AM, Kevin Hilman wrote:
> Santosh<santosh.shilimkar@ti.com>  writes:
>
>> On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote:
>>> From: Charulatha V<charu@ti.com>
>>>
>>> Currently gpio_context array used to save gpio bank's context, is used only for
>>> OMAP3 architecture. Move gpio_context as part of gpio_bank structure so that it
>>> can be specific to each gpio bank and can be used for any OMAP architecture
>>>
>>> Signed-off-by: Charulatha V<charu@ti.com>
>>> ---
>> Few comments.
>>
>
> [...]
>
>>> @@ -1494,33 +1490,31 @@ void omap2_gpio_resume_after_idle(void)
>>>    void omap_gpio_save_context(void)
>>>    {
>>>    	struct gpio_bank *bank;
>>> -	int i = 0;
>>>
>>>    	list_for_each_entry(bank,&omap_gpio_list, node) {
>>> -		i++;
>>>
>>>    		if (!bank->loses_context)
>>>    			continue;
>>>
>>> -		gpio_context[i].irqenable1 =
>>> +		bank->context.irqenable1 =
>>>    			__raw_readl(bank->base + OMAP24XX_GPIO_IRQENABLE1);
>>> -		gpio_context[i].irqenable2 =
>>> +		bank->context.irqenable2 =
>>>    			__raw_readl(bank->base + OMAP24XX_GPIO_IRQENABLE2);
>>
>> The context restore procedure should be done carefully. For instance
>> IRQ enabled register should be restored last to avoid any spurious
>> interrupts.
>
> For the sake of clean, easy-to-review patches, this kind of functional
> change should be a separate patch.
>
> The goal of $SUBJECT patch is simply to move the context struct into the
> bank struct, not change the order of the save restore.
>
> Any changing of the order of save/restore should be in a dedicated patch
> with a descriptive changelog since that is changing behavior of the code.
>
Agree.

Regards
Santosh