Re: [RFC PATCH 04/11] omap4: SDP: Pass regulator_init_data from DT

Grant Likely
2011-09-15T22:16:12Z

On Thu, Sep 15, 2011 at 02:46:18PM +0100, Mark Brown wrote:
> On Thu, Sep 15, 2011 at 04:52:00PM +0530, Rajendra Nayak wrote:
>
> > +Required properties:
> > +- compatible: Must be "regulator","ti,twl-reg";
>
> I'd expect listings for the specific chips too.
>
> > + xyz-regulator: regulator@0 {
> > + compatible = "regulator","ti,twl-reg";
> > + ti,reg-id = <37>; /* TWL6030_REG_VAUX1_6030 */
>
> These magic numbers are *very* Linux specific, we should have a better
> way of specifying regulators - I'd off the top of my head expect that
> the compatible property would identify the regulator.

Yes, that is exactly what it should do.

g.