Re: [RFC PATCH 01/11] OMAP: TWL: Clean up mode and ops mask passed from board files

Mark Brown
2011-09-15T13:32:37Z

On Thu, Sep 15, 2011 at 04:51:57PM +0530, Rajendra Nayak wrote:
> The TWL driver seems to set the default .valid_modes_mask to
> (REGULATOR_MODE_NORMAL | REGULATOR_MODE_STANDBY) and .valid_ops_mask
> to (REGULATOR_CHANGE_VOLTAGE | REGULATOR_CHANGE_MODE | REGULATOR_CHANGE_STATUS)
> for all the registered regulators.
>
> There is no need for all the board files to pass this information
> additionally, when the driver already sets them by default.

"the driver"? This sounds very buggy...