Re: [PATCH 1/2] mfd: twl6030: fix lockdep recursion warning on setting wake IRQs

Santosh Shilimkar
2011-09-27T05:14:54Z

On Tuesday 27 September 2011 05:14 AM, Todd Poynor wrote:
> LOCKDEP explicitly sets all irq_desc locks as a single lock-class,
> causing "possible recursive locking detected" when the TWL RTC
> driver calls through enable_irq_wake to twl6030_irq_set_wake,
> which recursively calls irq_set_irq_wake. Although the
> irq_desc and lock are different, LOCKDEP treats these as
> equivalent, presumably due to problems that can be incurred
> when locking more than one irq_desc, so best to avoid this.
>
> Suspend/resume actions implemented as PM notifiers to avoid
> touch the TWL core for this.
>
> Signed-off-by: Todd Poynor <toddpoynor@google.com>
> ---
>
> This patch applies on top of the patch from Santosh:
> [PATCH] mfd: twl6030: Setup irq_wake infrastructure.
>
> If PM notifiers aren't preferred then could change
> twl-core to add suspend/resume callbacks, was trying to
> make a lower-impact change.
>
> This complexity assumes there are systems that include twl6030
> and don't want its IRQs to act as wakeup. Alternatively,
> could just always enable wake for twl6030's IRQ.
>
Both options would mostly end up with same lines
of code :)
The patch looks good to me .
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>

Regards
Santosh