Re: [PATCH 1/2] mfd: twl6030: fix lockdep recursion warning on setting wake IRQs

Samuel Ortiz
2011-10-04T09:53:52Z

Hi Todd,

On Mon, Sep 26, 2011 at 04:44:23PM -0700, Todd Poynor wrote:
> LOCKDEP explicitly sets all irq_desc locks as a single lock-class,
> causing "possible recursive locking detected" when the TWL RTC
> driver calls through enable_irq_wake to twl6030_irq_set_wake,
> which recursively calls irq_set_irq_wake. Although the
> irq_desc and lock are different, LOCKDEP treats these as
> equivalent, presumably due to problems that can be incurred
> when locking more than one irq_desc, so best to avoid this.
>
> Suspend/resume actions implemented as PM notifiers to avoid
> touch the TWL core for this.
Thanks for that, I applied this patch.

Cheers,
Samuel.

--
Intel Open Source Technology Centre