From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH v3 4/4] OMAP_VOUT: Don't trigger updates in omap_vout_probe Date: Tue, 27 Sep 2011 12:32:39 +0530 Message-ID: <4E81750F.7060200@ti.com> References: <1317038365-30650-1-git-send-email-archit@ti.com> <1317038365-30650-5-git-send-email-archit@ti.com> <1317103833.1991.6.camel@deskari> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:33798 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751327Ab1I0HCW (ORCPT ); Tue, 27 Sep 2011 03:02:22 -0400 In-Reply-To: <1317103833.1991.6.camel@deskari> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Valkeinen, Tomi" Cc: "Hiremath, Vaibhav" , "linux-omap@vger.kernel.org" , "Semwal, Sumit" , "linux-media@vger.kernel.org" On Tuesday 27 September 2011 11:40 AM, Valkeinen, Tomi wrote: > On Mon, 2011-09-26 at 17:29 +0530, Archit Taneja wrote: >> Remove the code in omap_vout_probe() which calls display->driver->update() for >> all the displays. This isn't correct because: >> >> - An update in probe doesn't make sense, because we don't have any valid content >> to show at this time. >> - Calling update for a panel which isn't enabled is not supported by DSS2. This >> leads to a crash at probe. > > Calling update() on a disabled panel should not crash... Where is the > crash coming from? you are right, the crash isn't coming from the updates. I see the crash when we have 4 dss devices in our board file. The last display pointer is corrupted in that case. I'm trying to figure out why. Archit > > Tomi > >