From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH v2 2/6] OMAP4: Clock: round_rate and recalc functions for DPLL_ABE Date: Wed, 28 Sep 2011 10:37:39 -0500 Message-ID: <4E833F43.9000406@ti.com> References: <1316195263-14951-1-git-send-email-jon-hunter@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:59084 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752413Ab1I1Php (ORCPT ); Wed, 28 Sep 2011 11:37:45 -0400 In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: Mike Turquette , linux-omap , linux-arm Hi Paul, On 9/28/2011 1:59, Paul Walmsley wrote: > Hi Jon and Mike, > > On Fri, 16 Sep 2011, Jon Hunter wrote: > >> From: Mike Turquette >> >> OMAP4 DPLL_ABE can enable a 4X multipler on top of the normal MN multipler >> and divider. This is achieved by setting CM_CLKMODE_DPLL_ABE.DPLL_REGM4XEN >> bit in CKGEN module of CM1. From the OMAP4 TRM: >> >> Fdpll = Fref x 2 x (4 x M/(N+1)) in case REGM4XEN bit field is set (only >> applicable to DPLL_ABE). >> >> Add new round_rate() and recalc() functions for OMAP4, that check the >> setting of REGM4XEN bit and handle this appropriately. The new functions >> are a simple wrapper on top of the existing omap2_dpll_round_rate() and >> omap2_dpll_get_rate() functions to handle the REGM4XEN bit. >> >> The REGM4XEN bit is only implemented for the ABE DPLL on OMAP4 and so >> only dpll_abe_ck uses omap4_dpll_regm4xen_round_rate() and >> omap4_dpll_regm4xen_recalc() functions. >> >> Signed-off-by: Mike Turquette >> Tested-by: Jon Hunter > > Some changes have been made to this patch here, to fix a few minor bugs in > error paths and to add documentation and Jon's Signed-off-by: (since he's > in the submittal chain). > > Care to review and send any comments? Otherwise, I plan to queue this > revised version for 3.2. Looks good to me. Thanks for fixes and documentation. Cheers Jon