Re: [PATCH 2/9] regulator: helper routine to extract regulator_init_data

Mark Brown
2011-09-27T12:10:05Z

On Tue, Sep 27, 2011 at 03:42:45PM +0530, Rajendra Nayak wrote:

> + init_data = devm_kzalloc(dev, sizeof(struct regulator_init_data),
> + GFP_KERNEL);
> + if (!init_data)
> + return NULL; /* Out of memory? */

This means that the init data will be kept around for the entire
lifetime of the device rather than being discarded.

> + init_data->supply_regulator = (char *)of_get_property(dev->of_node,
> + "regulator-supplies", NULL);

I'd expect that in the device tree world the supply regulator would
reference the node for that regulator.

> /* voltage output range (inclusive) - for voltage control */
> - int min_uV;
> - int max_uV;
> + u32 min_uV;
> + u32 max_uV;
>
> - int uV_offset;
> + u32 uV_offset;
>
> /* current output range (inclusive) - for current control */
> - int min_uA;
> - int max_uA;
> + u32 min_uA;
> + u32 max_uA;

Hrm, I think loosing the signs here is bad karma - negative voltages do
exist after all.