From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH 28/30] ARM: omap: select CPU_FREQ_TABLE where needed Date: Mon, 03 Oct 2011 15:03:30 +0530 Message-ID: <4E89816A.5050704@ti.com> References: <1317566760-25681-1-git-send-email-arnd@arndb.de> <1317566760-25681-29-git-send-email-arnd@arndb.de> <4E894A95.5030107@ti.com> <5173921.eT2vCfT35d@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from na3sys009aog116.obsmtp.com ([74.125.149.240]:42460 "EHLO na3sys009aog116.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753788Ab1JCJdg (ORCPT ); Mon, 3 Oct 2011 05:33:36 -0400 In-Reply-To: <5173921.eT2vCfT35d@wuerfel> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Arnd Bergmann Cc: Tony Lindgren , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org On Monday 03 October 2011 02:45 PM, Arnd Bergmann wrote: > On Monday 03 October 2011 11:09:33 Santosh Shilimkar wrote: >>> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig >>> index bb8f4a6..f7ef9f4 100644 >>> --- a/arch/arm/plat-omap/Kconfig >>> +++ b/arch/arm/plat-omap/Kconfig >>> @@ -217,6 +217,11 @@ config OMAP_PM_NOOP >>> >>> endchoice >>> >>> +config OMAP_CPU_FREQ >>> + def_bool "y" >>> + depends on CPU_FREQ >>> + select CPU_FREQ_TABLE >>> + >>> endmenu >> With CPUFREQ series from Kevin [1], I don't think we need this any-more. > > I guess if it's needed, it should at least be moved to the new cpufreq > location. > Probably you are right. CPU_FREQ_TABLE is selected today if CPU_FREQ_STAT or CPU_FREQ_GOV_ONDEMAND is selected. Without these two enabled, in won't be selected. >> More so, I didn't find OMAP_CPU_FREQ is being used anywhere on mainline. > > Yes, OMAP_CPU_FREQ is a symbol that is intentionally unused, with the > only purpose of selecting CPU_FREQ_TABLE if any omap platform together > with CPU_FREQ is enabled. > I see. This wasn't clear to me. > Let's drop this patch for now, if it is still needed as I think, I can > do a patch during the 3.2 cycle for the right location. > Ok. Regards Santosh