From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH 5/4] ARM: OMAP: Move set_globals initialization to happen in init_early Date: Fri, 07 Oct 2011 12:26:36 +0530 Message-ID: <4E8EA2A4.5070301@ti.com> References: <20111005004339.26980.31149.stgit@kaulin.local> <20111005014044.GZ6324@atomide.com> <20111006013656.GG6324@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from na3sys009aog104.obsmtp.com ([74.125.149.73]:60517 "EHLO na3sys009aog104.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389Ab1JGG4m (ORCPT ); Fri, 7 Oct 2011 02:56:42 -0400 Received: by mail-yx0-f175.google.com with SMTP id 17so4361944yxj.34 for ; Thu, 06 Oct 2011 23:56:41 -0700 (PDT) In-Reply-To: <20111006013656.GG6324@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: Nicolas Pitre , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org On Thursday 06 October 2011 07:06 AM, Tony Lindgren wrote: > * Nicolas Pitre [111004 18:17]: >> On Tue, 4 Oct 2011, Tony Lindgren wrote: >> >>> Otherwise we can't do generic map_io as we currently rely on >>> static mappings that work only because of arch_ioremap. >>> >>> Signed-off-by: Tony Lindgren >> >> That's great. >> >> Acked-by: Nicolas Pitre > > Here's an updated version with all the early ioremap > access converted to use L3/L4_IO_ADDRESS macros. Some > of this may not be needed after generic map_io, but until > then we can't use ioremap until in init_early after the > SoC detection is done. > > Regards, > > Tony > > > From: Tony Lindgren > Date: Tue, 4 Oct 2011 18:17:41 -0700 > Subject: [PATCH] ARM: OMAP: Move set_globals initialization to happen in init_early > > Otherwise we can't do generic map_io as we currently rely on > static mappings that work only because of arch_ioremap. > > Acked-by: Nicolas Pitre > Signed-off-by: Tony Lindgren > The changes looks fine to me. Though the ugly hard-coding is back with it, it's a step towards generic_io, so hopefully it won't have to stay for long time. Reviewed-by: Santosh Shilimkar Tested-by: Santosh Shilimkar considering it's commin