[PATCH] BUILD FIX:hwspinlock: do not return any value from void funtion

[PATCH] BUILD FIX:hwspinlock: do not return any value from void funtion

[Vaibhav Hiremath]

Fixes below compilation error -

  CC      arch/arm/mach-omap2/hwspinlock.o
  cc1: warnings being treated as errors
  In file included from arch/arm/mach-omap2/hwspinlock.c:22:0:
  include/linux/hwspinlock.h: In function '__hwspin_unlock':
  include/linux/hwspinlock.h:121:2: error: 'return' with a value, in function
  returning void
  make[1]: *** [arch/arm/mach-omap2/hwspinlock.o] Error 1
  make: *** [arch/arm/mach-omap2] Error 2

Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
---
 include/linux/hwspinlock.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/hwspinlock.h b/include/linux/hwspinlock.h
index 08a2fee..192710a 100644
--- a/include/linux/hwspinlock.h
+++ b/include/linux/hwspinlock.h
@@ -118,7 +118,7 @@ int __hwspin_trylock(struct hwspinlock *hwlock, int mode, unsigned long *flags)
 static inline
 void __hwspin_unlock(struct hwspinlock *hwlock, int mode, unsigned long *flags)
 {
-	return 0;
+	return;
 }

 static inline int hwspin_lock_get_id(struct hwspinlock *hwlock)
--
1.7.0.4

Re: [PATCH] BUILD FIX:hwspinlock: do not return any value from void funtion

[Igor Grinberg]

Hi Vaibhav,

On 11/07/11 14:58, Vaibhav Hiremath wrote:
> Fixes below compilation error -
> 
>   CC      arch/arm/mach-omap2/hwspinlock.o
>   cc1: warnings being treated as errors
>   In file included from arch/arm/mach-omap2/hwspinlock.c:22:0:
>   include/linux/hwspinlock.h: In function '__hwspin_unlock':
>   include/linux/hwspinlock.h:121:2: error: 'return' with a value, in function
>   returning void
>   make[1]: *** [arch/arm/mach-omap2/hwspinlock.o] Error 1
>   make: *** [arch/arm/mach-omap2] Error 2
> 
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> ---
>  include/linux/hwspinlock.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/hwspinlock.h b/include/linux/hwspinlock.h
> index 08a2fee..192710a 100644
> --- a/include/linux/hwspinlock.h
> +++ b/include/linux/hwspinlock.h
> @@ -118,7 +118,7 @@ int __hwspin_trylock(struct hwspinlock *hwlock, int mode, unsigned long *flags)
>  static inline
>  void __hwspin_unlock(struct hwspinlock *hwlock, int mode, unsigned long *flags)
>  {
> -	return 0;
> +	return;

Isn't it better to just remove this line?

>  }
> 
>  static inline int hwspin_lock_get_id(struct hwspinlock *hwlock)


-- 
Regards,
Igor.

RE: [PATCH] BUILD FIX:hwspinlock: do not return any value from void funtion

[Hiremath, Vaibhav]

> -----Original Message-----
> From: Igor Grinberg [mailto:grinberg@compulab.co.il]
> Sent: Monday, November 07, 2011 6:37 PM
> To: Hiremath, Vaibhav
> Cc: linux-omap@vger.kernel.org; tony@atomide.com; ohad@wizery.com
> Subject: Re: [PATCH] BUILD FIX:hwspinlock: do not return any value from
> void funtion
> 
> Hi Vaibhav,
> 
> On 11/07/11 14:58, Vaibhav Hiremath wrote:
> > Fixes below compilation error -
> >
> >   CC      arch/arm/mach-omap2/hwspinlock.o
> >   cc1: warnings being treated as errors
> >   In file included from arch/arm/mach-omap2/hwspinlock.c:22:0:
> >   include/linux/hwspinlock.h: In function '__hwspin_unlock':
> >   include/linux/hwspinlock.h:121:2: error: 'return' with a value, in
> function
> >   returning void
> >   make[1]: *** [arch/arm/mach-omap2/hwspinlock.o] Error 1
> >   make: *** [arch/arm/mach-omap2] Error 2
> >
> > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> > ---
> >  include/linux/hwspinlock.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/linux/hwspinlock.h b/include/linux/hwspinlock.h
> > index 08a2fee..192710a 100644
> > --- a/include/linux/hwspinlock.h
> > +++ b/include/linux/hwspinlock.h
> > @@ -118,7 +118,7 @@ int __hwspin_trylock(struct hwspinlock *hwlock, int
> mode, unsigned long *flags)
> >  static inline
> >  void __hwspin_unlock(struct hwspinlock *hwlock, int mode, unsigned long
> *flags)
> >  {
> > -	return 0;
> > +	return;
> 
> Isn't it better to just remove this line?
> 
[Hiremath, Vaibhav] Yeup, we can do that... Submitting it again.

Thanks,
Vaibhav

> >  }
> >
> >  static inline int hwspin_lock_get_id(struct hwspinlock *hwlock)
> 
> 
> --
> Regards,
> Igor.

Re: [PATCH] BUILD FIX:hwspinlock: do not return any value from void funtion

[Ohad Ben-Cohen]

On Mon, Nov 7, 2011 at 2:58 PM, Vaibhav Hiremath <hvaibhav@ti.com> wrote:
> Fixes below compilation error -

Thanks. We already have this fix queued up though (reported by Axel awhile ago).

RE: [PATCH] BUILD FIX:hwspinlock: do not return any value from void funtion

[Hiremath, Vaibhav]

> -----Original Message-----
> From: Ohad Ben-Cohen [mailto:ohad@wizery.com]
> Sent: Monday, November 07, 2011 7:25 PM
> To: Hiremath, Vaibhav
> Cc: linux-omap@vger.kernel.org; tony@atomide.com
> Subject: Re: [PATCH] BUILD FIX:hwspinlock: do not return any value from
> void funtion
> 
> On Mon, Nov 7, 2011 at 2:58 PM, Vaibhav Hiremath <hvaibhav@ti.com> wrote:
> > Fixes below compilation error -
> 
> Thanks. We already have this fix queued up though (reported by Axel awhile
> ago).
[Hiremath, Vaibhav] I did try to search before fixing this...but I did not find any patch for this. Can you point me to it?

If it is already queued up, no point in submitting it again.

Thanks,
Vaibhav

Re: [PATCH] BUILD FIX:hwspinlock: do not return any value from void funtion

[Ohad Ben-Cohen]

On Mon, Nov 7, 2011 at 3:58 PM, Hiremath, Vaibhav <hvaibhav@ti.com> wrote:
> [Hiremath, Vaibhav] I did try to search before fixing this...but I did not find any patch for this. Can you point me to it?

http://comments.gmane.org/gmane.linux.kernel/1210678

RE: [PATCH] BUILD FIX:hwspinlock: do not return any value from void funtion

[Hiremath, Vaibhav]

> -----Original Message-----
> From: Ohad Ben-Cohen [mailto:ohad@wizery.com]
> Sent: Monday, November 07, 2011 7:25 PM
> To: Hiremath, Vaibhav
> Cc: linux-omap@vger.kernel.org; tony@atomide.com
> Subject: Re: [PATCH] BUILD FIX:hwspinlock: do not return any value from
> void funtion
> 
> On Mon, Nov 7, 2011 at 2:58 PM, Vaibhav Hiremath <hvaibhav@ti.com> wrote:
> > Fixes below compilation error -
> 
> Thanks. We already have this fix queued up though (reported by Axel awhile
> ago).
Found it...

http://comments.gmane.org/gmane.linux.kernel/1210678

Thanks,
Vaibhav