[PATCH] OMAP2+: Fix Compilation break on current mainline

[PATCH] OMAP2+: Fix Compilation break on current mainline

[Govindraj.R]

I see below errors and warnings on latest mainline commit
b32fc0a0629bf5894b35f33554c118aacfd0d1e2 with omap2plus_defconfig.

Patch to fix the same.

arch/arm/plat-omap/dmtimer.c:184: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:184: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:184: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:215: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:215: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:215: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:228: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:228: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:228: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:234: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:234: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:234: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:240: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:240: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:240: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:248: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:248: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:248: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:294: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:294: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:294: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:302: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:302: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:302: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:316: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:316: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:316: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:344: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:344: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:344: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:361: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:361: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:361: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:380: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:380: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:380: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:406: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:406: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:406: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:443: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:443: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:443: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:468: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:468: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:468: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:494: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:494: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:494: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:517: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:517: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:517: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:534: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:534: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:534: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:549: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:549: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:549: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:561: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:561: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:561: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:572: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:572: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:572: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:587: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:587: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:587: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:604: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:604: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/arm/plat-omap/dmtimer.c:604: warning: parameter names (without types) in function declaration
arch/arm/plat-omap/dmtimer.c:746: error: expected declaration specifiers or '...' before string constant
arch/arm/plat-omap/dmtimer.c:746: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:746: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
arch/arm/plat-omap/dmtimer.c:746: warning: function declaration isn't a prototype
arch/arm/plat-omap/dmtimer.c:747: error: expected declaration specifiers or '...' before string constant
arch/arm/plat-omap/dmtimer.c:747: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:747: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
arch/arm/plat-omap/dmtimer.c:747: warning: function declaration isn't a prototype
arch/arm/plat-omap/dmtimer.c:748: error: expected declaration specifiers or '...' before string constant
arch/arm/plat-omap/dmtimer.c:748: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:748: warning: type defaults to 'int' in declaration of 'MODULE_ALIAS'
arch/arm/plat-omap/dmtimer.c:748: warning: function declaration isn't a prototype
arch/arm/plat-omap/dmtimer.c:749: error: expected declaration specifiers or '...' before string constant
arch/arm/plat-omap/dmtimer.c:749: warning: data definition has no type or storage class
arch/arm/plat-omap/dmtimer.c:749: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
arch/arm/plat-omap/dmtimer.c:749: warning: function declaration isn't a prototype
make[1]: *** [arch/arm/plat-omap/dmtimer.o] Error 1
make: *** [arch/arm/plat-omap] Error 2
make: *** Waiting for unfinished jobs....
arch/arm/mach-omap2/omap_l3_noc.c:240: error: expected ',' or ';' before 'MODULE_DEVICE_TABLE'
arch/arm/mach-omap2/omap_l3_noc.c:250: error: 'THIS_MODULE' undeclared here (not in a function)
make[1]: *** [arch/arm/mach-omap2/omap_l3_noc.o] Error 1
make: *** [arch/arm/mach-omap2] Error 2

Signed-off-by: Govindraj.R <govindraj.raja@ti.com>
---
Sorry for the noise if this is already fixed.

 arch/arm/mach-omap2/omap_l3_noc.c |    3 ++-
 arch/arm/plat-omap/dmtimer.c      |    1 +
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_l3_noc.c b/arch/arm/mach-omap2/omap_l3_noc.c
index c8b1bef..eacbe55 100644
--- a/arch/arm/mach-omap2/omap_l3_noc.c
+++ b/arch/arm/mach-omap2/omap_l3_noc.c
@@ -26,6 +26,7 @@
 #include <linux/interrupt.h>
 #include <linux/kernel.h>
 #include <linux/slab.h>
+#include <linux/module.h>
 
 #include "omap_l3_noc.h"
 
@@ -236,7 +237,7 @@ static int __devexit omap4_l3_remove(struct platform_device *pdev)
 static const struct of_device_id l3_noc_match[] = {
 	{.compatible = "ti,omap4-l3-noc", },
 	{},
-}
+};
 MODULE_DEVICE_TABLE(of, l3_noc_match);
 #else
 #define l3_noc_match NULL
diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c
index 2def4e1..b9acaca 100644
--- a/arch/arm/plat-omap/dmtimer.c
+++ b/arch/arm/plat-omap/dmtimer.c
@@ -39,6 +39,7 @@
 #include <linux/slab.h>
 #include <linux/err.h>
 #include <linux/pm_runtime.h>
+#include <linux/module.h>
 
 #include <plat/dmtimer.h>
 
-- 
1.7.4.1

Re: [PATCH] OMAP2+: Fix Compilation break on current mainline

[Shilimkar, Santosh]

On Mon, Nov 7, 2011 at 6:08 PM, Govindraj.R <govindraj.raja@ti.com> wrote:
> I see below errors and warnings on latest mainline commit
> b32fc0a0629bf5894b35f33554c118aacfd0d1e2 with omap2plus_defconfig.
>
> Patch to fix the same.
>
Patches are already posted and applied by Tony on linux-omap master.

http://www.spinics.net/lists/linux-omap/msg59848.html
http://www.spinics.net/lists/linux-omap/msg59847.html

Regards
Santosh

Re: [PATCH] OMAP2+: Fix Compilation break on current mainline

[Cousson, Benoit]

On 11/7/2011 1:59 PM, Shilimkar, Santosh wrote:
> On Mon, Nov 7, 2011 at 6:08 PM, Govindraj.R<govindraj.raja@ti.com>  wrote:
>> I see below errors and warnings on latest mainline commit
>> b32fc0a0629bf5894b35f33554c118aacfd0d1e2 with omap2plus_defconfig.
>>
>> Patch to fix the same.
>>
> Patches are already posted and applied by Tony on linux-omap master.

Except the missing semicolon... This is a similar issue that Ohad 
reported for hwspinlock.
It will build fine until you will try to build the omap_l3_noc as a module.


Govind,
You can maybe repost a fix for that one only.

Regards,
Benoit

[PATCH] OMAP2+: Fix Compilation error on current mainline

[Govindraj.R]

Patch to fix below compilation error on latest mainline commit
b32fc0a0629bf5894b35f33554c118aacfd0d1e2 with omap2plus_defconfig.

arch/arm/mach-omap2/omap_l3_noc.c:250: error: 'THIS_MODULE' undeclared here (not in a function)
make[1]: *** [arch/arm/mach-omap2/omap_l3_noc.o] Error 1

Signed-off-by: Govindraj.R <govindraj.raja@ti.com>
---
 arch/arm/mach-omap2/omap_l3_noc.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_l3_noc.c b/arch/arm/mach-omap2/omap_l3_noc.c
index c8b1bef..c2cc196 100644
--- a/arch/arm/mach-omap2/omap_l3_noc.c
+++ b/arch/arm/mach-omap2/omap_l3_noc.c
@@ -26,6 +26,7 @@
 #include <linux/interrupt.h>
 #include <linux/kernel.h>
 #include <linux/slab.h>
+#include <linux/module.h>
 
 #include "omap_l3_noc.h"
 
-- 
1.7.4.1

Re: [PATCH] OMAP2+: Fix Compilation error on current mainline

[Shilimkar, Santosh]

On Tue, Nov 8, 2011 at 11:58 AM, Govindraj.R <govindraj.raja@ti.com> wrote:
> Patch to fix below compilation error on latest mainline commit
> b32fc0a0629bf5894b35f33554c118aacfd0d1e2 with omap2plus_defconfig.
>
> arch/arm/mach-omap2/omap_l3_noc.c:250: error: 'THIS_MODULE' undeclared here (not in a function)
> make[1]: *** [arch/arm/mach-omap2/omap_l3_noc.o] Error 1
>
> Signed-off-by: Govindraj.R <govindraj.raja@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>

Re: [PATCH] OMAP2+: Fix Compilation error on current mainline

[Cousson, Benoit]

Hi Govind,

On 11/8/2011 7:28 AM, Govindraj.R wrote:
> Patch to fix below compilation error on latest mainline commit
> b32fc0a0629bf5894b35f33554c118aacfd0d1e2 with omap2plus_defconfig.
>
> arch/arm/mach-omap2/omap_l3_noc.c:250: error: 'THIS_MODULE' undeclared here (not in a function)
> make[1]: *** [arch/arm/mach-omap2/omap_l3_noc.o] Error 1
>
> Signed-off-by: Govindraj.R<govindraj.raja@ti.com>
> ---
>   arch/arm/mach-omap2/omap_l3_noc.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_l3_noc.c b/arch/arm/mach-omap2/omap_l3_noc.c
> index c8b1bef..c2cc196 100644
> --- a/arch/arm/mach-omap2/omap_l3_noc.c
> +++ b/arch/arm/mach-omap2/omap_l3_noc.c
> @@ -26,6 +26,7 @@
>   #include<linux/interrupt.h>
>   #include<linux/kernel.h>
>   #include<linux/slab.h>
> +#include<linux/module.h>

That one is already fixed by Axel Lin, and already pulled by Tony.

http://www.spinics.net/lists/linux-omap/msg59847.html

This is the missing semi-colon that still need to be fixed.

Regards,
Benoit

Re: [PATCH] OMAP2+: Fix Compilation error on current mainline

[Santosh Shilimkar]

On Tuesday 08 November 2011 04:16 PM, Cousson, Benoit wrote:
> Hi Govind,
> 
> On 11/8/2011 7:28 AM, Govindraj.R wrote:
>> Patch to fix below compilation error on latest mainline commit
>> b32fc0a0629bf5894b35f33554c118aacfd0d1e2 with omap2plus_defconfig.
>>
>> arch/arm/mach-omap2/omap_l3_noc.c:250: error: 'THIS_MODULE' undeclared
>> here (not in a function)
>> make[1]: *** [arch/arm/mach-omap2/omap_l3_noc.o] Error 1
>>
>> Signed-off-by: Govindraj.R<govindraj.raja@ti.com>
>> ---
>>   arch/arm/mach-omap2/omap_l3_noc.c |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/omap_l3_noc.c
>> b/arch/arm/mach-omap2/omap_l3_noc.c
>> index c8b1bef..c2cc196 100644
>> --- a/arch/arm/mach-omap2/omap_l3_noc.c
>> +++ b/arch/arm/mach-omap2/omap_l3_noc.c
>> @@ -26,6 +26,7 @@
>>   #include<linux/interrupt.h>
>>   #include<linux/kernel.h>
>>   #include<linux/slab.h>
>> +#include<linux/module.h>
> 
> That one is already fixed by Axel Lin, and already pulled by Tony.
> 
> http://www.spinics.net/lists/linux-omap/msg59847.html
> 
> This is the missing semi-colon that still need to be fixed.
> 
Opps. I missed that one while acking the patch.
Indeed the semi-colon one was agreed to be the left over
in the last patch discussion.

Regards
Santosh

Re: [PATCH] OMAP2+: Fix Compilation error on current mainline

[Govindraj]

On Tue, Nov 8, 2011 at 4:24 PM, Santosh Shilimkar
<santosh.shilimkar@ti.com> wrote:
> On Tuesday 08 November 2011 04:16 PM, Cousson, Benoit wrote:
>> Hi Govind,
>>
>> On 11/8/2011 7:28 AM, Govindraj.R wrote:
>>> Patch to fix below compilation error on latest mainline commit
>>> b32fc0a0629bf5894b35f33554c118aacfd0d1e2 with omap2plus_defconfig.
>>>
>>> arch/arm/mach-omap2/omap_l3_noc.c:250: error: 'THIS_MODULE' undeclared
>>> here (not in a function)
>>> make[1]: *** [arch/arm/mach-omap2/omap_l3_noc.o] Error 1
>>>
>>> Signed-off-by: Govindraj.R<govindraj.raja@ti.com>
>>> ---
>>>   arch/arm/mach-omap2/omap_l3_noc.c |    1 +
>>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-omap2/omap_l3_noc.c
>>> b/arch/arm/mach-omap2/omap_l3_noc.c
>>> index c8b1bef..c2cc196 100644
>>> --- a/arch/arm/mach-omap2/omap_l3_noc.c
>>> +++ b/arch/arm/mach-omap2/omap_l3_noc.c
>>> @@ -26,6 +26,7 @@
>>>   #include<linux/interrupt.h>
>>>   #include<linux/kernel.h>
>>>   #include<linux/slab.h>
>>> +#include<linux/module.h>
>>
>> That one is already fixed by Axel Lin, and already pulled by Tony.
>>
>> http://www.spinics.net/lists/linux-omap/msg59847.html
>>
>> This is the missing semi-colon that still need to be fixed.
>>
> Opps. I missed that one while acking the patch.
> Indeed the semi-colon one was agreed to be the left over
> in the last patch discussion.

Sorry, my bad sent the wrong patch here's the right one.[1]

--
Thanks,
Govindraj.R

[1]:

From 9d244c0dea4de10ab9052fc1fe7bde8846ad389e Mon Sep 17 00:00:00 2001
From: Govindraj.R <govindraj.raja@ti.com>
Date: Tue, 8 Nov 2011 16:57:22 +0530
Subject: [PATCH] OMAP2+: Fix Compilation error on current mainline

Fix below compilation failure on mainline kernel commit id
1ea6b8f48918282bdca0b32a34095504ee65bab5

arch/arm/mach-omap2/omap_l3_noc.c:240: error: expected ',' or ';'
before 'MODULE_DEVICE_TABLE'

Signed-off-by: Govindraj.R <govindraj.raja@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
 arch/arm/mach-omap2/omap_l3_noc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_l3_noc.c
b/arch/arm/mach-omap2/omap_l3_noc.c
index 6a66aa5..d15225f 100644
--- a/arch/arm/mach-omap2/omap_l3_noc.c
+++ b/arch/arm/mach-omap2/omap_l3_noc.c
@@ -237,7 +237,7 @@ static int __devexit omap4_l3_remove(struct
platform_device *pdev)
 static const struct of_device_id l3_noc_match[] = {
 	{.compatible = "ti,omap4-l3-noc", },
 	{},
-}
+};
 MODULE_DEVICE_TABLE(of, l3_noc_match);
 #else
 #define l3_noc_match NULL
-- 
1.7.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP2+: Fix Compilation error on current mainline

[Cousson, Benoit]

On 11/8/2011 12:59 PM, Govindraj wrote:
> On Tue, Nov 8, 2011 at 4:24 PM, Santosh Shilimkar
> <santosh.shilimkar@ti.com>  wrote:

[...]

>> Opps. I missed that one while acking the patch.
>> Indeed the semi-colon one was agreed to be the left over
>> in the last patch discussion.
>
> Sorry, my bad sent the wrong patch here's the right one.[1]
>
> --
> Thanks,
> Govindraj.R
>
> [1]:
>
>  From 9d244c0dea4de10ab9052fc1fe7bde8846ad389e Mon Sep 17 00:00:00 2001
> From: Govindraj.R<govindraj.raja@ti.com>
> Date: Tue, 8 Nov 2011 16:57:22 +0530
> Subject: [PATCH] OMAP2+: Fix Compilation error on current mainline
>
> Fix below compilation failure on mainline kernel commit id
> 1ea6b8f48918282bdca0b32a34095504ee65bab5
>
> arch/arm/mach-omap2/omap_l3_noc.c:240: error: expected ',' or ';'
> before 'MODULE_DEVICE_TABLE'

The issue is that 3.2-rc1 does not have that build error anymore...
It should appear only with this driver built as a module, and that's not 
possible yet for the l3_noc.

The fix is still good to have, but the changelog should probably be updated.

Regards,
Benoit

Re: [PATCH] OMAP2+: Fix Compilation error on current mainline

[Govindraj]

On Tue, Nov 8, 2011 at 8:55 PM, Cousson, Benoit <b-cousson@ti.com> wrote:
> On 11/8/2011 12:59 PM, Govindraj wrote:
>>
>> On Tue, Nov 8, 2011 at 4:24 PM, Santosh Shilimkar
>> <santosh.shilimkar@ti.com>  wrote:
>
> [...]
>
>>> Opps. I missed that one while acking the patch.
>>> Indeed the semi-colon one was agreed to be the left over
>>> in the last patch discussion.
>>
>> Sorry, my bad sent the wrong patch here's the right one.[1]
>>
>> --
>> Thanks,
>> Govindraj.R
>>
>> [1]:
>>
>>  From 9d244c0dea4de10ab9052fc1fe7bde8846ad389e Mon Sep 17 00:00:00 2001
>> From: Govindraj.R<govindraj.raja@ti.com>
>> Date: Tue, 8 Nov 2011 16:57:22 +0530
>> Subject: [PATCH] OMAP2+: Fix Compilation error on current mainline
>>
>> Fix below compilation failure on mainline kernel commit id
>> 1ea6b8f48918282bdca0b32a34095504ee65bab5
>>
>> arch/arm/mach-omap2/omap_l3_noc.c:240: error: expected ',' or ';'
>> before 'MODULE_DEVICE_TABLE'
>
> The issue is that 3.2-rc1 does not have that build error anymore...
> It should appear only with this driver built as a module, and that's not
> possible yet for the l3_noc.
>
> The fix is still good to have, but the changelog should probably be updated.
>

Have posted a updated patch.

http://www.mail-archive.com/linux-omap@vger.kernel.org/msg58415.html

--
Thanks,
Govindraj.R
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html