linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Cousson, Benoit" <b-cousson@ti.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Jamie Iles <jamie@jamieiles.com>, Paul Walmsley <paul@pwsan.com>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"tony@atomide.com" <tony@atomide.com>,
	Ming Lei <ming.lei@canonical.com>,
	"khilman@deeprootsystems.com" <khilman@deeprootsystems.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 4/7] arm: omap4: hwmod: introduce emu hwmod
Date: Fri, 11 Nov 2011 16:12:49 +0100	[thread overview]
Message-ID: <4EBD3B71.5000801@ti.com> (raw)
In-Reply-To: <20111111145833.GL12410@mudshark.cambridge.arm.com>

Hi Will,

On 11/11/2011 3:58 PM, Will Deacon wrote:
> Hi Benoit,
>
> On Fri, Nov 11, 2011 at 02:56:05PM +0000, Cousson, Benoit wrote:
>> It will come soon... along with the updated patch for reg-names support.
>
> Actually, I was hoping you could help Ming Lei with the hwmod stuff :)

And I'll do :-)

We already started looking at that with Paul a couple of days ago, but 
the organization of the debugss IPs inside MPUSS is a little bit messy 
in OMAP :-)

For the moment the cti IRQs are attached to the MPU subsystem which make 
sense for the HW partitioning point of view.
Unfortunately, these debug IPs are accessed through an external L3_EMU 
configuration bus and not using some internal bus inside the MPUSS.
In the memory maps they are thus all located inside the 
0x54000000-0x54164FFF.

So for the driver point of view, it might be better to assign these IRQs 
to the debugss IP instead of the MPUSS IP.

The MPU will then only have the PL310 IRQ.

static struct omap_hwmod_irq_info omap44xx_mpu_irqs[] = {
	{ .name = "pl310", .irq = 0 + OMAP44XX_IRQ_GIC_START },
	{ .irq = -1 }
};

The debugss one will have the cti ones, that will start at 0 and thus 
will make them even accessible using the index.

static struct omap_hwmod_irq_info omap44xx_debugss_irqs[] = {
	{ .name = "cti0", .irq = 1 + OMAP44XX_IRQ_GIC_START },
	{ .name = "cti1", .irq = 2 + OMAP44XX_IRQ_GIC_START },
	{ .irq = -1 }
};

I need to fix this IRQ mapping and then I'll be able to send a hwmod 
version of this debugss virtual IP that should help Ming.

Regards,
Benoit




  reply	other threads:[~2011-11-11 15:13 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-24 14:45 [PATCH v5 0/7] arm: pmu: support pmu/perf on OMAP4 ming.lei
2011-10-24 14:45 ` [PATCH v5 1/7] arm: introduce cross trigger interface helpers ming.lei
2011-10-24 14:45 ` [PATCH v5 2/7] arm: pmu: allow platform specific irq enable/disable handling ming.lei
2011-11-01  3:26   ` Ming Lei
2011-11-01 12:52     ` Will Deacon
2011-10-24 14:45 ` [PATCH v5 3/7] arm: perf: support device with other non-irq resources ming.lei
2011-10-24 15:08   ` Will Deacon
2011-10-25  1:09     ` Ming Lei
2011-10-25  8:34       ` Will Deacon
2011-10-25  8:44         ` Paul Walmsley
2011-10-25 10:23           ` Ming Lei
2011-10-25 11:00             ` Paul Walmsley
2011-11-08  9:25               ` Ming Lei
2011-11-08 12:17                 ` Will Deacon
2011-10-24 14:45 ` [PATCH v5 4/7] arm: omap4: hwmod: introduce emu hwmod ming.lei
2011-11-08 15:26   ` Paul Walmsley
2011-11-09  9:56     ` Ming Lei
2011-11-10  9:02       ` Paul Walmsley
2011-11-11 11:41         ` Will Deacon
2011-11-11 11:47           ` Jamie Iles
2011-11-11 11:59             ` Will Deacon
2011-11-11 14:56             ` Cousson, Benoit
2011-11-11 14:58               ` Will Deacon
2011-11-11 15:12                 ` Cousson, Benoit [this message]
2011-11-11 15:22                   ` Will Deacon
2011-11-18 12:58         ` Cousson, Benoit
2011-11-18 14:56           ` Will Deacon
2011-11-19 14:42             ` Ming Lei
2011-11-20  3:27               ` Paul Walmsley
2011-11-21 13:58                 ` Will Deacon
2011-11-21 14:53                   ` Ming Lei
2011-11-21 15:16                     ` Will Deacon
2011-11-21 15:30                       ` Ming Lei
2011-11-19 14:37           ` Ming Lei
2011-11-27  1:58           ` Paul Walmsley
2011-11-27  2:07             ` Paul Walmsley
2011-11-29 16:19               ` Cousson, Benoit
2011-11-29 18:11                 ` Paul Walmsley
2011-11-30 16:20                   ` Cousson, Benoit
2011-11-08 15:42   ` Paul Walmsley
2011-11-09 11:33     ` Ming Lei
2011-10-24 14:45 ` [PATCH v5 5/7] arm: omap4: create pmu device via hwmod ming.lei
2011-10-24 14:45 ` [PATCH v5 6/7] arm: omap4: support pmu ming.lei
2011-11-23 17:47   ` Rabin Vincent
2011-11-25  0:37     ` Ming Lei
2011-10-24 14:45 ` [PATCH v5 7/7] arm: omap4: pmu: support runtime pm ming.lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EBD3B71.5000801@ti.com \
    --to=b-cousson@ti.com \
    --cc=jamie@jamieiles.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=ming.lei@canonical.com \
    --cc=paul@pwsan.com \
    --cc=tony@atomide.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).