From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCH] ARM: OMAP: mcbsp: Fix possible memory corruption Date: Mon, 12 Dec 2011 13:22:28 +0200 Message-ID: <4EE5E3F4.6060701@bitmer.com> References: <1323678976-4119-1-git-send-email-jarkko.nikula@bitmer.com> <1323679106-4191-1-git-send-email-jarkko.nikula@bitmer.com> <4EE5D639.8080608@compulab.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from [213.157.87.50] ([213.157.87.50]:59848 "EHLO bitmer.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752052Ab1LLLXc (ORCPT ); Mon, 12 Dec 2011 06:23:32 -0500 In-Reply-To: <4EE5D639.8080608@compulab.co.il> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Igor Grinberg Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tony@atomide.com, neilb@suse.de Hi On 12/12/2011 12:23 PM, Igor Grinberg wrote: > On 12/12/11 10:38, Jarkko Nikula wrote: >> Commits 09d28d ("ARM: OMAP: mcbsp: Start generalize omap2_mcbsp_set_clks_src") >> and 7bc0c4 ("ARM: OMAP: mcbsp: Start generalize signal muxing functions") >> incorrectly set two struct omap_mcbsp_platform_data fields after >> omap_device_build_ss and kfree calls. >> >> Fix this by moving these pdata assignments before those calls. >> >> Signed-off-by: Jarkko Nikula >> Reported-by: neilb@suse.de > Perhaps, should be: > Reported-by: NeilBrown > and > Cc: [3.1] > as for below. >> --- >> For 3.2, 3.1 is ok. >> --- No need to cc stable since the issue is not in stable kernels. -- Jarkko