Re: [PATCH] am35xx-emac: move generic EMAC init to separate file

[Ilya Yanok <yanok@emcraft.com>]

Hi Tony,

On 08.12.2011 04:15, Tony Lindgren wrote:
>> AM35xx SoCs include DaVinci EMAC IP. Initialization code in
>> board-am3517evm.c is pretty board independent and will work for any
>> AM35xx based board so move this code to it's own file to be reused by
>> other boards.
> 
> Should this be just called emac-common.c? Or is it so am35xx specific
> that it won't work with others?

Uh.. I'm not sure but I thought that EMAC is present only on am35xx SoCs...

>> +	clk_add_alias(NULL, dev_name(&am35xx_emac_device.dev),
>> +		      "emac_clk", &am35xx_emac_device.dev);
>> +	clk_add_alias(NULL, dev_name(&am35xx_mdio_device.dev),
>> +		      "phy_clk", &am35xx_emac_device.dev);
> 
> Hmm after moving the code and should be a separate patch, don't
> we already have these clock aliases in cloc3xxx_data.c?

No, we have
CLK("davinci_emac", "emac_clk"...) and
CLK("davinci_emac", "phy_clk"...)
while drivers want ("davinci_emac", NULL) and ("davinci_mdio", NULL).

Probably we have to fix the clock definitions instead of adding the aliases.

So, should I post this as a separate patch?

Regards, Ilya.