From: Ilya Yanok <yanok@emcraft.com>
To: "Hiremath, Vaibhav" <hvaibhav@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"sasha_d@emcraft.com" <sasha_d@emcraft.com>
Subject: Re: [PATCH V2] am35xx-emac: move generic EMAC init to separate file
Date: Wed, 21 Dec 2011 13:14:47 +0400 [thread overview]
Message-ID: <4EF1A387.2030708@emcraft.com> (raw)
In-Reply-To: <79CD15C6BA57404B839C016229A409A8063F1C@DBDE01.ent.ti.com>
Hi,
On 21.12.2011 10:07, Hiremath, Vaibhav wrote:
>> +static struct resource am35xx_mdio_resources[] = {
>> + {
>> + .start = AM35XX_IPSS_EMAC_BASE + AM35XX_EMAC_MDIO_OFFSET,
>> + .end = AM35XX_IPSS_EMAC_BASE + AM35XX_EMAC_MDIO_OFFSET +
>> + SZ_4K - 1,
>> + .flags = IORESOURCE_MEM,
>> + },
>> +};
> This will not be board independent, using AM35xx everywhere.
Why? It will work for any AM35XX based board. Probably we can try and
make it work with EMACs on other AM3XXXs but I don't have these devices.
> To make it completely board independent, you should get all this platform
> specific data from board file. Probably have emac_init() function here and
> pass the data.
Hm.. This data is SoC-dependent not board-dependent, what's the reason
to move it to the board file?
> Do you know any other platform or device using this IP?
Yes, I have a couple of AM3517 based boards that use this IP.
Regards, Ilya.
next prev parent reply other threads:[~2011-12-21 9:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 23:26 [PATCH V2] am35xx-emac: move generic EMAC init to separate file Ilya Yanok
2011-12-21 6:07 ` Hiremath, Vaibhav
2011-12-21 9:14 ` Ilya Yanok [this message]
2011-12-21 9:50 ` Hiremath, Vaibhav
2012-03-01 9:19 ` [PATCH v3 1/2] ARM: OMAP: " Igor Grinberg
2012-03-05 18:19 ` Tony Lindgren
2012-03-01 9:19 ` [PATCH 2/2] ARM: OMAP3: cm-t3517: add EMAC support Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF1A387.2030708@emcraft.com \
--to=yanok@emcraft.com \
--cc=hvaibhav@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=sasha_d@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).