* [PATCH] OMAP: DSS2: Support for UMSH-8173MD TFT panel
@ 2011-12-16 17:23 Daniel Mack
2011-12-16 17:30 ` [PATCH v2] " Daniel Mack
0 siblings, 1 reply; 7+ messages in thread
From: Daniel Mack @ 2011-12-16 17:23 UTC (permalink / raw)
To: linux-omap; +Cc: Daniel Mack, Tomi Valkeinen, Florian Tobias Schandinat
Signed-off-by: Daniel Mack <zonque@gmail.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
---
drivers/video/omap2/displays/panel-generic-dpi.c | 25 ++++++++++++++++++++++
1 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/drivers/video/omap2/displays/panel-generic-dpi.c b/drivers/video/omap2/displays/panel-generic-dpi.c
index 519c47d..8ce72ca 100644
--- a/drivers/video/omap2/displays/panel-generic-dpi.c
+++ b/drivers/video/omap2/displays/panel-generic-dpi.c
@@ -297,6 +297,31 @@ static struct panel_config generic_dpi_panels[] = {
.name = "apollon",
},
+
+ /* Microtips Technologies - UMSH-8173MD */
+ {
+ {
+ .x_res = 800,
+ .y_res = 480,
+
+ .pixel_clock = 34560,
+
+ .hsw = 13,
+ .hfp = 101,
+ .hbp = 101,
+
+ .vsw = 23,
+ .vfp = 1,
+ .vbp = 1,
+ },
+ .acbi = 0x0,
+ .acb = 0x1,
+ .config = OMAP_DSS_LCD_TFT | OMAP_DSS_LCD_IVS |
+ OMAP_DSS_LCD_IHS | OMAP_DSS_LCD_IPC,
+ .power_on_delay = 100,
+ .power_off_delay = 0,
+ .name = "UMSH-8173MD",
+ },
};
struct panel_drv_data {
--
1.7.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v2] OMAP: DSS2: Support for UMSH-8173MD TFT panel
2011-12-16 17:23 [PATCH] OMAP: DSS2: Support for UMSH-8173MD TFT panel Daniel Mack
@ 2011-12-16 17:30 ` Daniel Mack
2011-12-20 8:40 ` Tomi Valkeinen
0 siblings, 1 reply; 7+ messages in thread
From: Daniel Mack @ 2011-12-16 17:30 UTC (permalink / raw)
To: linux-omap; +Cc: Daniel Mack, Tomi Valkeinen, Florian Tobias Schandinat
Signed-off-by: Daniel Mack <zonque@gmail.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
---
v2 is a resent with ".power_on_delay" and ".acb" values corrected.
drivers/video/omap2/displays/panel-generic-dpi.c | 25 ++++++++++++++++++++++
1 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/drivers/video/omap2/displays/panel-generic-dpi.c b/drivers/video/omap2/displays/panel-generic-dpi.c
index 519c47d..cbcf164 100644
--- a/drivers/video/omap2/displays/panel-generic-dpi.c
+++ b/drivers/video/omap2/displays/panel-generic-dpi.c
@@ -297,6 +297,31 @@ static struct panel_config generic_dpi_panels[] = {
.name = "apollon",
},
+
+ /* Microtips Technologies - UMSH-8173MD */
+ {
+ {
+ .x_res = 800,
+ .y_res = 480,
+
+ .pixel_clock = 34560,
+
+ .hsw = 13,
+ .hfp = 101,
+ .hbp = 101,
+
+ .vsw = 23,
+ .vfp = 1,
+ .vbp = 1,
+ },
+ .acbi = 0x0,
+ .acb = 0x0,
+ .config = OMAP_DSS_LCD_TFT | OMAP_DSS_LCD_IVS |
+ OMAP_DSS_LCD_IHS | OMAP_DSS_LCD_IPC,
+ .power_on_delay = 0,
+ .power_off_delay = 0,
+ .name = "UMSH-8173MD",
+ },
};
struct panel_drv_data {
--
1.7.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2] OMAP: DSS2: Support for UMSH-8173MD TFT panel
2011-12-16 17:30 ` [PATCH v2] " Daniel Mack
@ 2011-12-20 8:40 ` Tomi Valkeinen
2011-12-20 9:54 ` [PATCH v3] " Daniel Mack
0 siblings, 1 reply; 7+ messages in thread
From: Tomi Valkeinen @ 2011-12-20 8:40 UTC (permalink / raw)
To: Daniel Mack; +Cc: linux-omap, Florian Tobias Schandinat
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
Hi,
On Fri, 2011-12-16 at 18:30 +0100, Daniel Mack wrote:
> Signed-off-by: Daniel Mack <zonque@gmail.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
> ---
>
> v2 is a resent with ".power_on_delay" and ".acb" values corrected.
The code itself is fine, but please provide a commit description.
Patches should always have a commit description, even if the patch is
trivial and the desc would be more or less the same as the subject.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3] OMAP: DSS2: Support for UMSH-8173MD TFT panel
2011-12-20 8:40 ` Tomi Valkeinen
@ 2011-12-20 9:54 ` Daniel Mack
2011-12-22 23:03 ` Daniel Mack
2012-01-03 9:21 ` Tomi Valkeinen
0 siblings, 2 replies; 7+ messages in thread
From: Daniel Mack @ 2011-12-20 9:54 UTC (permalink / raw)
To: linux-omap; +Cc: Daniel Mack, Tomi Valkeinen, Florian Tobias Schandinat
This patch adds support for Microtip Technologies' UMSH-8173MD 800x480
RGB TFT panel. Tested with an OMAP3 board.
Signed-off-by: Daniel Mack <zonque@gmail.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
---
drivers/video/omap2/displays/panel-generic-dpi.c | 25 ++++++++++++++++++++++
1 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/drivers/video/omap2/displays/panel-generic-dpi.c b/drivers/video/omap2/displays/panel-generic-dpi.c
index 519c47d..cbcf164 100644
--- a/drivers/video/omap2/displays/panel-generic-dpi.c
+++ b/drivers/video/omap2/displays/panel-generic-dpi.c
@@ -297,6 +297,31 @@ static struct panel_config generic_dpi_panels[] = {
.name = "apollon",
},
+
+ /* Microtips Technologies - UMSH-8173MD */
+ {
+ {
+ .x_res = 800,
+ .y_res = 480,
+
+ .pixel_clock = 34560,
+
+ .hsw = 13,
+ .hfp = 101,
+ .hbp = 101,
+
+ .vsw = 23,
+ .vfp = 1,
+ .vbp = 1,
+ },
+ .acbi = 0x0,
+ .acb = 0x0,
+ .config = OMAP_DSS_LCD_TFT | OMAP_DSS_LCD_IVS |
+ OMAP_DSS_LCD_IHS | OMAP_DSS_LCD_IPC,
+ .power_on_delay = 0,
+ .power_off_delay = 0,
+ .name = "UMSH-8173MD",
+ },
};
struct panel_drv_data {
--
1.7.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v3] OMAP: DSS2: Support for UMSH-8173MD TFT panel
2011-12-20 9:54 ` [PATCH v3] " Daniel Mack
@ 2011-12-22 23:03 ` Daniel Mack
2012-01-03 9:21 ` Tomi Valkeinen
1 sibling, 0 replies; 7+ messages in thread
From: Daniel Mack @ 2011-12-22 23:03 UTC (permalink / raw)
To: Daniel Mack; +Cc: linux-omap, Tomi Valkeinen, Florian Tobias Schandinat
On 12/20/2011 10:54 AM, Daniel Mack wrote:
> This patch adds support for Microtip Technologies' UMSH-8173MD 800x480
> RGB TFT panel. Tested with an OMAP3 board.
Does this version appear more suitable?
Thanks,
Daniel
>
> Signed-off-by: Daniel Mack <zonque@gmail.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
> ---
> drivers/video/omap2/displays/panel-generic-dpi.c | 25 ++++++++++++++++++++++
> 1 files changed, 25 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/omap2/displays/panel-generic-dpi.c b/drivers/video/omap2/displays/panel-generic-dpi.c
> index 519c47d..cbcf164 100644
> --- a/drivers/video/omap2/displays/panel-generic-dpi.c
> +++ b/drivers/video/omap2/displays/panel-generic-dpi.c
> @@ -297,6 +297,31 @@ static struct panel_config generic_dpi_panels[] = {
>
> .name = "apollon",
> },
> +
> + /* Microtips Technologies - UMSH-8173MD */
> + {
> + {
> + .x_res = 800,
> + .y_res = 480,
> +
> + .pixel_clock = 34560,
> +
> + .hsw = 13,
> + .hfp = 101,
> + .hbp = 101,
> +
> + .vsw = 23,
> + .vfp = 1,
> + .vbp = 1,
> + },
> + .acbi = 0x0,
> + .acb = 0x0,
> + .config = OMAP_DSS_LCD_TFT | OMAP_DSS_LCD_IVS |
> + OMAP_DSS_LCD_IHS | OMAP_DSS_LCD_IPC,
> + .power_on_delay = 0,
> + .power_off_delay = 0,
> + .name = "UMSH-8173MD",
> + },
> };
>
> struct panel_drv_data {
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v3] OMAP: DSS2: Support for UMSH-8173MD TFT panel
2011-12-20 9:54 ` [PATCH v3] " Daniel Mack
2011-12-22 23:03 ` Daniel Mack
@ 2012-01-03 9:21 ` Tomi Valkeinen
2012-01-03 10:36 ` Daniel Mack
1 sibling, 1 reply; 7+ messages in thread
From: Tomi Valkeinen @ 2012-01-03 9:21 UTC (permalink / raw)
To: Daniel Mack; +Cc: linux-omap, Florian Tobias Schandinat
[-- Attachment #1: Type: text/plain, Size: 1573 bytes --]
On Tue, 2011-12-20 at 10:54 +0100, Daniel Mack wrote:
> This patch adds support for Microtip Technologies' UMSH-8173MD 800x480
> RGB TFT panel. Tested with an OMAP3 board.
>
> Signed-off-by: Daniel Mack <zonque@gmail.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
> ---
> drivers/video/omap2/displays/panel-generic-dpi.c | 25 ++++++++++++++++++++++
> 1 files changed, 25 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/omap2/displays/panel-generic-dpi.c b/drivers/video/omap2/displays/panel-generic-dpi.c
> index 519c47d..cbcf164 100644
> --- a/drivers/video/omap2/displays/panel-generic-dpi.c
> +++ b/drivers/video/omap2/displays/panel-generic-dpi.c
> @@ -297,6 +297,31 @@ static struct panel_config generic_dpi_panels[] = {
>
> .name = "apollon",
> },
> +
> + /* Microtips Technologies - UMSH-8173MD */
> + {
> + {
> + .x_res = 800,
> + .y_res = 480,
> +
> + .pixel_clock = 34560,
> +
> + .hsw = 13,
> + .hfp = 101,
> + .hbp = 101,
> +
> + .vsw = 23,
> + .vfp = 1,
> + .vbp = 1,
> + },
> + .acbi = 0x0,
> + .acb = 0x0,
> + .config = OMAP_DSS_LCD_TFT | OMAP_DSS_LCD_IVS |
> + OMAP_DSS_LCD_IHS | OMAP_DSS_LCD_IPC,
> + .power_on_delay = 0,
> + .power_off_delay = 0,
> + .name = "UMSH-8173MD",
Looks fine, except the panel name is not in line with the other panel
names. I suggest "microtips_umsh_8173md". I can apply the patch and
make the change if you are ok with the name.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v3] OMAP: DSS2: Support for UMSH-8173MD TFT panel
2012-01-03 9:21 ` Tomi Valkeinen
@ 2012-01-03 10:36 ` Daniel Mack
0 siblings, 0 replies; 7+ messages in thread
From: Daniel Mack @ 2012-01-03 10:36 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: linux-omap, Florian Tobias Schandinat
On 01/03/2012 10:21 AM, Tomi Valkeinen wrote:
> On Tue, 2011-12-20 at 10:54 +0100, Daniel Mack wrote:
>> This patch adds support for Microtip Technologies' UMSH-8173MD 800x480
>> RGB TFT panel. Tested with an OMAP3 board.
>>
>> Signed-off-by: Daniel Mack <zonque@gmail.com>
>> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
>> ---
>> drivers/video/omap2/displays/panel-generic-dpi.c | 25 ++++++++++++++++++++++
>> 1 files changed, 25 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/video/omap2/displays/panel-generic-dpi.c b/drivers/video/omap2/displays/panel-generic-dpi.c
>> index 519c47d..cbcf164 100644
>> --- a/drivers/video/omap2/displays/panel-generic-dpi.c
>> +++ b/drivers/video/omap2/displays/panel-generic-dpi.c
>> @@ -297,6 +297,31 @@ static struct panel_config generic_dpi_panels[] = {
>>
>> .name = "apollon",
>> },
>> +
>> + /* Microtips Technologies - UMSH-8173MD */
>> + {
>> + {
>> + .x_res = 800,
>> + .y_res = 480,
>> +
>> + .pixel_clock = 34560,
>> +
>> + .hsw = 13,
>> + .hfp = 101,
>> + .hbp = 101,
>> +
>> + .vsw = 23,
>> + .vfp = 1,
>> + .vbp = 1,
>> + },
>> + .acbi = 0x0,
>> + .acb = 0x0,
>> + .config = OMAP_DSS_LCD_TFT | OMAP_DSS_LCD_IVS |
>> + OMAP_DSS_LCD_IHS | OMAP_DSS_LCD_IPC,
>> + .power_on_delay = 0,
>> + .power_off_delay = 0,
>> + .name = "UMSH-8173MD",
>
> Looks fine, except the panel name is not in line with the other panel
> names. I suggest "microtips_umsh_8173md". I can apply the patch and
> make the change if you are ok with the name.
Yes, please do! :)
Thanks,
Daniel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-01-03 10:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-16 17:23 [PATCH] OMAP: DSS2: Support for UMSH-8173MD TFT panel Daniel Mack
2011-12-16 17:30 ` [PATCH v2] " Daniel Mack
2011-12-20 8:40 ` Tomi Valkeinen
2011-12-20 9:54 ` [PATCH v3] " Daniel Mack
2011-12-22 23:03 ` Daniel Mack
2012-01-03 9:21 ` Tomi Valkeinen
2012-01-03 10:36 ` Daniel Mack
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).