From: Archit <a0393947@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
archit@ti.com, rob@ti.com
Subject: Re: [PATCH 5/6] OMAPDSS: DISPC: move fifo threhold calc to dispc.c
Date: Mon, 16 Jan 2012 15:29:43 +0530 [thread overview]
Message-ID: <4F13F50F.9060705@ti.com> (raw)
In-Reply-To: <1326707861.1875.1.camel@deskari>
On Monday 16 January 2012 03:27 PM, Tomi Valkeinen wrote:
> On Sat, 2012-01-14 at 01:30 +0530, Archit wrote:
>> Hi,
>>
>> On Friday 13 January 2012 05:16 PM, Tomi Valkeinen wrote:
>>> Move fifo threshold calculation into dispc.c, as the thresholds are
>>> really dispc internal thing.
>>>
>>> Signed-off-by: Tomi Valkeinen<tomi.valkeinen@ti.com>
>>
>> <snip>
>>
>>> diff --git a/drivers/video/omap2/dss/dsi.c b/drivers/video/omap2/dss/dsi.c
>>> index 511ae2a..1cbb7a5 100644
>>> --- a/drivers/video/omap2/dss/dsi.c
>>> +++ b/drivers/video/omap2/dss/dsi.c
>>> @@ -4524,14 +4524,6 @@ int omapdss_dsi_enable_te(struct omap_dss_device *dssdev, bool enable)
>>> }
>>> EXPORT_SYMBOL(omapdss_dsi_enable_te);
>>>
>>> -void dsi_get_overlay_fifo_thresholds(enum omap_plane plane,
>>> - u32 fifo_size, u32 burst_size,
>>> - u32 *fifo_low, u32 *fifo_high)
>>> -{
>>> - *fifo_high = fifo_size - burst_size;
>>> - *fifo_low = fifo_size - burst_size * 2;
>>> -}
>>
>> We are removing the special treatment for overlays connected to DSI done
>> before. Won't this cause the issues you saw with DSI in OMAP3?
>
> That's true. I had it in mind at some point, but I seem to have
> forgotten it.
>
> The problem with OMAP3, DSI and fifo thresholds was never cleared, and I
> haven't seen an errata about it, so there's a slim chance that it was
> only a problem with the particular setup.
>
> Are you back at the office yet? If I recall right, you had an OMAP3 DSI
> cmd mode board?
Not yet, I'll try it out when I get back.
>
> Anyway, I guess it's safest if I add a hack there, which tunes the
> thresholds a bit differently for OMAP3 DSI.
Yes, you could have that, we have to rewrite the whole threshold
calculation later on anyway.
Archit
>
> Tomi
>
next prev parent reply other threads:[~2012-01-16 9:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 11:46 [PATCH 0/6] OMAPDSS: naive fifomerge support Tomi Valkeinen
2012-01-13 11:46 ` [PATCH 1/6] OMAPDSS: FEAT: Add FIFO_MERGE feature Tomi Valkeinen
2012-01-13 11:46 ` [PATCH 2/6] OMAPDSS: APPLY: add fifo merge support funcs Tomi Valkeinen
2012-01-13 11:46 ` [PATCH 3/6] OMAPDSS: APPLY: add fifo-merge support Tomi Valkeinen
2012-01-13 11:46 ` [PATCH 4/6] OMAPDSS: DISPC: print fifo threshold values in bytes Tomi Valkeinen
2012-01-13 11:46 ` [PATCH 5/6] OMAPDSS: DISPC: move fifo threhold calc to dispc.c Tomi Valkeinen
2012-01-13 20:00 ` Archit
2012-01-16 9:57 ` Tomi Valkeinen
2012-01-16 9:59 ` Archit [this message]
2012-01-18 8:10 ` Tomi Valkeinen
2012-01-13 11:46 ` [PATCH 6/6] OMAPDSS: DISPC: Add naive threshold calc for fifomerge Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F13F50F.9060705@ti.com \
--to=a0393947@ti.com \
--cc=archit@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rob@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).