From: "Cousson, Benoit" <b-cousson@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: "Palande, Ameya" <ameya.palande@ti.com>,
linux-omap@vger.kernel.org, Kevin Hilman <khilman@ti.com>
Subject: Re: [PATCH] OMAP4: Clock: Force a DPLL clkdm/pwrdm ON before a relock
Date: Wed, 25 Jan 2012 23:08:54 +0100 [thread overview]
Message-ID: <4F207D76.9070707@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1201251205220.5324@utopia.booyaka.com>
Hi Paul,
On 1/25/2012 8:05 PM, Paul Walmsley wrote:
> Hi
>
> On Tue, 24 Jan 2012, Palande, Ameya wrote:
>
>> Any update on this?
>
> Looks good to me, but have the scripts been updated?
Nope. The clkdm was never populated for DPLL in OMAP4 so far. We will
have to add that extra parameters to every DPLLs in theory if we want to
be consistent.
Hopefully, the information is available in the data source, so this is
just a matter of printing it in the DPLL node template.
Regards,
Benoit
>
> Also could you please cc linux-arm-kernel@lists.infradead.org?
>
> - Paul
>
>>
>> On Fri, Jan 20, 2012 at 11:53 AM, Palande, Ameya<ameya.palande@ti.com> wrote:
>>> Any update on this?
>>>
>>> On Thu, Jan 19, 2012 at 11:22 AM, Ameya Palande<ameya.palande@ti.com> wrote:
>>>> From: Rajendra Nayak<rnayak@ti.com>
>>>>
>>>> All DPLLs except USB are in ALWON powerdomain. Make sure the
>>>> clkdm/pwrdm for USB DPLL (l3init) is turned on before attempting
>>>> a DPLL relock. So, mark the database accordingly.
>>>>
>>>> Without this fix, it was seen that DPLL relock fails while testing
>>>> relock in a loop of USB DPLL.
>>>>
>>>> CC: Nishanth Menon<nm@ti.com>
>>>> Tested-by: Ameya Palande<ameya.palande@ti.com>
>>>> Signed-off-by: Rajendra Nayak<rnayak@ti.com>
>>>> ---
>>>> arch/arm/mach-omap2/clock44xx_data.c | 1 +
>>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c
>>>> index 08e86d7..9519374 100644
>>>> --- a/arch/arm/mach-omap2/clock44xx_data.c
>>>> +++ b/arch/arm/mach-omap2/clock44xx_data.c
>>>> @@ -974,6 +974,7 @@ static struct clk dpll_usb_ck = {
>>>> .recalc =&omap3_dpll_recalc,
>>>> .round_rate =&omap2_dpll_round_rate,
>>>> .set_rate =&omap3_noncore_dpll_set_rate,
>>>> + .clkdm_name = "l3_init_clkdm",
>>>> };
>>>>
>>>> static struct clk dpll_usb_clkdcoldo_ck = {
>>>> --
>>>> 1.7.4.1
>>>>
>>
>
>
> - Paul
next prev parent reply other threads:[~2012-01-25 22:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 19:22 [PATCH] OMAP4: Clock: Force a DPLL clkdm/pwrdm ON before a relock Ameya Palande
2012-01-20 19:53 ` Palande, Ameya
2012-01-25 1:37 ` Palande, Ameya
2012-01-25 19:05 ` Paul Walmsley
2012-01-25 22:08 ` Cousson, Benoit [this message]
2012-01-25 22:46 ` Palande, Ameya
2012-01-25 22:54 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F207D76.9070707@ti.com \
--to=b-cousson@ti.com \
--cc=ameya.palande@ti.com \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox