* [PATCH] OMAP4: Clock: Force a DPLL clkdm/pwrdm ON before a relock @ 2012-01-19 19:22 Ameya Palande 2012-01-20 19:53 ` Palande, Ameya 0 siblings, 1 reply; 7+ messages in thread From: Ameya Palande @ 2012-01-19 19:22 UTC (permalink / raw) To: linux-omap; +Cc: rnayak, ameya.palande, nm From: Rajendra Nayak <rnayak@ti.com> All DPLLs except USB are in ALWON powerdomain. Make sure the clkdm/pwrdm for USB DPLL (l3init) is turned on before attempting a DPLL relock. So, mark the database accordingly. Without this fix, it was seen that DPLL relock fails while testing relock in a loop of USB DPLL. CC: Nishanth Menon <nm@ti.com> Tested-by: Ameya Palande <ameya.palande@ti.com> Signed-off-by: Rajendra Nayak <rnayak@ti.com> --- arch/arm/mach-omap2/clock44xx_data.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c index 08e86d7..9519374 100644 --- a/arch/arm/mach-omap2/clock44xx_data.c +++ b/arch/arm/mach-omap2/clock44xx_data.c @@ -974,6 +974,7 @@ static struct clk dpll_usb_ck = { .recalc = &omap3_dpll_recalc, .round_rate = &omap2_dpll_round_rate, .set_rate = &omap3_noncore_dpll_set_rate, + .clkdm_name = "l3_init_clkdm", }; static struct clk dpll_usb_clkdcoldo_ck = { -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] OMAP4: Clock: Force a DPLL clkdm/pwrdm ON before a relock 2012-01-19 19:22 [PATCH] OMAP4: Clock: Force a DPLL clkdm/pwrdm ON before a relock Ameya Palande @ 2012-01-20 19:53 ` Palande, Ameya 2012-01-25 1:37 ` Palande, Ameya 0 siblings, 1 reply; 7+ messages in thread From: Palande, Ameya @ 2012-01-20 19:53 UTC (permalink / raw) To: linux-omap; +Cc: rnayak, ameya.palande, nm Any update on this? On Thu, Jan 19, 2012 at 11:22 AM, Ameya Palande <ameya.palande@ti.com> wrote: > From: Rajendra Nayak <rnayak@ti.com> > > All DPLLs except USB are in ALWON powerdomain. Make sure the > clkdm/pwrdm for USB DPLL (l3init) is turned on before attempting > a DPLL relock. So, mark the database accordingly. > > Without this fix, it was seen that DPLL relock fails while testing > relock in a loop of USB DPLL. > > CC: Nishanth Menon <nm@ti.com> > Tested-by: Ameya Palande <ameya.palande@ti.com> > Signed-off-by: Rajendra Nayak <rnayak@ti.com> > --- > arch/arm/mach-omap2/clock44xx_data.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c > index 08e86d7..9519374 100644 > --- a/arch/arm/mach-omap2/clock44xx_data.c > +++ b/arch/arm/mach-omap2/clock44xx_data.c > @@ -974,6 +974,7 @@ static struct clk dpll_usb_ck = { > .recalc = &omap3_dpll_recalc, > .round_rate = &omap2_dpll_round_rate, > .set_rate = &omap3_noncore_dpll_set_rate, > + .clkdm_name = "l3_init_clkdm", > }; > > static struct clk dpll_usb_clkdcoldo_ck = { > -- > 1.7.4.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] OMAP4: Clock: Force a DPLL clkdm/pwrdm ON before a relock 2012-01-20 19:53 ` Palande, Ameya @ 2012-01-25 1:37 ` Palande, Ameya 2012-01-25 19:05 ` Paul Walmsley 0 siblings, 1 reply; 7+ messages in thread From: Palande, Ameya @ 2012-01-25 1:37 UTC (permalink / raw) To: linux-omap; +Cc: Kevin Hilman, paul Any update on this? On Fri, Jan 20, 2012 at 11:53 AM, Palande, Ameya <ameya.palande@ti.com> wrote: > Any update on this? > > On Thu, Jan 19, 2012 at 11:22 AM, Ameya Palande <ameya.palande@ti.com> wrote: >> From: Rajendra Nayak <rnayak@ti.com> >> >> All DPLLs except USB are in ALWON powerdomain. Make sure the >> clkdm/pwrdm for USB DPLL (l3init) is turned on before attempting >> a DPLL relock. So, mark the database accordingly. >> >> Without this fix, it was seen that DPLL relock fails while testing >> relock in a loop of USB DPLL. >> >> CC: Nishanth Menon <nm@ti.com> >> Tested-by: Ameya Palande <ameya.palande@ti.com> >> Signed-off-by: Rajendra Nayak <rnayak@ti.com> >> --- >> arch/arm/mach-omap2/clock44xx_data.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c >> index 08e86d7..9519374 100644 >> --- a/arch/arm/mach-omap2/clock44xx_data.c >> +++ b/arch/arm/mach-omap2/clock44xx_data.c >> @@ -974,6 +974,7 @@ static struct clk dpll_usb_ck = { >> .recalc = &omap3_dpll_recalc, >> .round_rate = &omap2_dpll_round_rate, >> .set_rate = &omap3_noncore_dpll_set_rate, >> + .clkdm_name = "l3_init_clkdm", >> }; >> >> static struct clk dpll_usb_clkdcoldo_ck = { >> -- >> 1.7.4.1 >> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] OMAP4: Clock: Force a DPLL clkdm/pwrdm ON before a relock 2012-01-25 1:37 ` Palande, Ameya @ 2012-01-25 19:05 ` Paul Walmsley 2012-01-25 22:08 ` Cousson, Benoit 2012-01-25 22:46 ` Palande, Ameya 0 siblings, 2 replies; 7+ messages in thread From: Paul Walmsley @ 2012-01-25 19:05 UTC (permalink / raw) To: Palande, Ameya; +Cc: linux-omap, Kevin Hilman [-- Attachment #1: Type: TEXT/PLAIN, Size: 1655 bytes --] Hi On Tue, 24 Jan 2012, Palande, Ameya wrote: > Any update on this? Looks good to me, but have the scripts been updated? Also could you please cc linux-arm-kernel@lists.infradead.org? - Paul > > On Fri, Jan 20, 2012 at 11:53 AM, Palande, Ameya <ameya.palande@ti.com> wrote: > > Any update on this? > > > > On Thu, Jan 19, 2012 at 11:22 AM, Ameya Palande <ameya.palande@ti.com> wrote: > >> From: Rajendra Nayak <rnayak@ti.com> > >> > >> All DPLLs except USB are in ALWON powerdomain. Make sure the > >> clkdm/pwrdm for USB DPLL (l3init) is turned on before attempting > >> a DPLL relock. So, mark the database accordingly. > >> > >> Without this fix, it was seen that DPLL relock fails while testing > >> relock in a loop of USB DPLL. > >> > >> CC: Nishanth Menon <nm@ti.com> > >> Tested-by: Ameya Palande <ameya.palande@ti.com> > >> Signed-off-by: Rajendra Nayak <rnayak@ti.com> > >> --- > >> arch/arm/mach-omap2/clock44xx_data.c | 1 + > >> 1 files changed, 1 insertions(+), 0 deletions(-) > >> > >> diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c > >> index 08e86d7..9519374 100644 > >> --- a/arch/arm/mach-omap2/clock44xx_data.c > >> +++ b/arch/arm/mach-omap2/clock44xx_data.c > >> @@ -974,6 +974,7 @@ static struct clk dpll_usb_ck = { > >> .recalc = &omap3_dpll_recalc, > >> .round_rate = &omap2_dpll_round_rate, > >> .set_rate = &omap3_noncore_dpll_set_rate, > >> + .clkdm_name = "l3_init_clkdm", > >> }; > >> > >> static struct clk dpll_usb_clkdcoldo_ck = { > >> -- > >> 1.7.4.1 > >> > - Paul ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] OMAP4: Clock: Force a DPLL clkdm/pwrdm ON before a relock 2012-01-25 19:05 ` Paul Walmsley @ 2012-01-25 22:08 ` Cousson, Benoit 2012-01-25 22:46 ` Palande, Ameya 1 sibling, 0 replies; 7+ messages in thread From: Cousson, Benoit @ 2012-01-25 22:08 UTC (permalink / raw) To: Paul Walmsley; +Cc: Palande, Ameya, linux-omap, Kevin Hilman Hi Paul, On 1/25/2012 8:05 PM, Paul Walmsley wrote: > Hi > > On Tue, 24 Jan 2012, Palande, Ameya wrote: > >> Any update on this? > > Looks good to me, but have the scripts been updated? Nope. The clkdm was never populated for DPLL in OMAP4 so far. We will have to add that extra parameters to every DPLLs in theory if we want to be consistent. Hopefully, the information is available in the data source, so this is just a matter of printing it in the DPLL node template. Regards, Benoit > > Also could you please cc linux-arm-kernel@lists.infradead.org? > > - Paul > >> >> On Fri, Jan 20, 2012 at 11:53 AM, Palande, Ameya<ameya.palande@ti.com> wrote: >>> Any update on this? >>> >>> On Thu, Jan 19, 2012 at 11:22 AM, Ameya Palande<ameya.palande@ti.com> wrote: >>>> From: Rajendra Nayak<rnayak@ti.com> >>>> >>>> All DPLLs except USB are in ALWON powerdomain. Make sure the >>>> clkdm/pwrdm for USB DPLL (l3init) is turned on before attempting >>>> a DPLL relock. So, mark the database accordingly. >>>> >>>> Without this fix, it was seen that DPLL relock fails while testing >>>> relock in a loop of USB DPLL. >>>> >>>> CC: Nishanth Menon<nm@ti.com> >>>> Tested-by: Ameya Palande<ameya.palande@ti.com> >>>> Signed-off-by: Rajendra Nayak<rnayak@ti.com> >>>> --- >>>> arch/arm/mach-omap2/clock44xx_data.c | 1 + >>>> 1 files changed, 1 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c >>>> index 08e86d7..9519374 100644 >>>> --- a/arch/arm/mach-omap2/clock44xx_data.c >>>> +++ b/arch/arm/mach-omap2/clock44xx_data.c >>>> @@ -974,6 +974,7 @@ static struct clk dpll_usb_ck = { >>>> .recalc =&omap3_dpll_recalc, >>>> .round_rate =&omap2_dpll_round_rate, >>>> .set_rate =&omap3_noncore_dpll_set_rate, >>>> + .clkdm_name = "l3_init_clkdm", >>>> }; >>>> >>>> static struct clk dpll_usb_clkdcoldo_ck = { >>>> -- >>>> 1.7.4.1 >>>> >> > > > - Paul ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] OMAP4: Clock: Force a DPLL clkdm/pwrdm ON before a relock 2012-01-25 19:05 ` Paul Walmsley 2012-01-25 22:08 ` Cousson, Benoit @ 2012-01-25 22:46 ` Palande, Ameya 2012-01-25 22:54 ` Paul Walmsley 1 sibling, 1 reply; 7+ messages in thread From: Palande, Ameya @ 2012-01-25 22:46 UTC (permalink / raw) To: Paul Walmsley; +Cc: linux-omap, Kevin Hilman Hi Paul, On Wed, Jan 25, 2012 at 11:05 AM, Paul Walmsley <paul@pwsan.com> wrote: > Hi > > On Tue, 24 Jan 2012, Palande, Ameya wrote: > >> Any update on this? > > Looks good to me, but have the scripts been updated? Thanks for the review! > Also could you please cc linux-arm-kernel@lists.infradead.org? Sorry. Will do it from next time. Cheers, Ameya. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] OMAP4: Clock: Force a DPLL clkdm/pwrdm ON before a relock 2012-01-25 22:46 ` Palande, Ameya @ 2012-01-25 22:54 ` Paul Walmsley 0 siblings, 0 replies; 7+ messages in thread From: Paul Walmsley @ 2012-01-25 22:54 UTC (permalink / raw) To: Palande, Ameya; +Cc: linux-omap, Kevin Hilman Hi Ameya On Wed, 25 Jan 2012, Palande, Ameya wrote: > On Wed, Jan 25, 2012 at 11:05 AM, Paul Walmsley <paul@pwsan.com> wrote: > > > Also could you please cc linux-arm-kernel@lists.infradead.org? > > Sorry. Will do it from next time. Please do it on this one too. Otherwise I will have to do it :-) - Paul ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-01-25 22:54 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-01-19 19:22 [PATCH] OMAP4: Clock: Force a DPLL clkdm/pwrdm ON before a relock Ameya Palande 2012-01-20 19:53 ` Palande, Ameya 2012-01-25 1:37 ` Palande, Ameya 2012-01-25 19:05 ` Paul Walmsley 2012-01-25 22:08 ` Cousson, Benoit 2012-01-25 22:46 ` Palande, Ameya 2012-01-25 22:54 ` Paul Walmsley
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox