From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Justin P. Mattock" Subject: Re: [PATCH] staging: tidspbridge: enable watchdog by default Date: Tue, 31 Jan 2012 19:22:38 -0800 Message-ID: <4F28AFFE.109@gmail.com> References: <1328058094-28483-1-git-send-email-felipe.contreras@gmail.com> <20120201011239.GA797@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devel-bounces@linuxdriverproject.org Sender: devel-bounces@linuxdriverproject.org To: Felipe Contreras Cc: STAGING SUBSYSTEM , Jiri Kosina , Greg KH , Felipe Contreras , linux-omap@vger.kernel.org List-Id: linux-omap@vger.kernel.org On 01/31/2012 05:37 PM, Felipe Contreras wrote: > On Wed, Feb 1, 2012 at 3:12 AM, Greg KH wrote: >> On Wed, Feb 01, 2012 at 03:01:32AM +0200, Felipe Contreras wrote: >>> From: Felipe Contreras >>> >>> The public images have it enabled, it's safer, and we get rid of this >>> warning: >>> >>> WARNING: at arch/arm/mach-omap2/omap_l3_smx.c:162 omap3_l3_app_irq+0x114/0x15c() >>> In-band Error seen by IVA_SS at address 0 >>> Modules linked in: bridgedriver(C+) mailbox_mach mailbox ipv6 g_ether >>> [] (unwind_backtrace+0x0/0xec) from [] (warn_slowpath_common+0x4c/0x64) >>> [] (warn_slowpath_common+0x4c/0x64) from [] (warn_slowpath_fmt+0x2c/0x3c) >>> [] (warn_slowpath_fmt+0x2c/0x3c) from [] (omap3_l3_app_irq+0x114/0x15c) >>> [] (omap3_l3_app_irq+0x114/0x15c) from [] (handle_irq_event_percpu+0x28/0x174) >>> [] (handle_irq_event_percpu+0x28/0x174) from [] (handle_irq_event+0x28/0x38) >>> [] (handle_irq_event+0x28/0x38) from [] (handle_level_irq+0xb8/0xe0) >>> [] (handle_level_irq+0xb8/0xe0) from [] (generic_handle_irq+0x28/0x30) >>> [] (generic_handle_irq+0x28/0x30) from [] (handle_IRQ+0x60/0x84) >>> [] (handle_IRQ+0x60/0x84) from [] (__irq_svc+0x34/0x80) >>> [] (__irq_svc+0x34/0x80) from [] (v7_dma_inv_range+0x34/0x48) >>> [] (v7_dma_inv_range+0x34/0x48) from [] (dma_cache_maint_page+0x2c/0x34) >>> [] (dma_cache_maint_page+0x2c/0x34) from [] (___dma_page_dev_to_cpu+0x24/0x68) >>> [] (___dma_page_dev_to_cpu+0x24/0x68) from [] (dma_unmap_sg+0x40/0x64) >>> [] (dma_unmap_sg+0x40/0x64) from [] (omap_hsmmc_post_req+0x3c/0x48) >>> [] (omap_hsmmc_post_req+0x3c/0x48) from [] (mmc_post_req+0x18/0x1c) >>> [] (mmc_post_req+0x18/0x1c) from [] (mmc_start_req+0xd4/0xec) >>> [] (mmc_start_req+0xd4/0xec) from [] (mmc_blk_issue_rw_rq+0x64/0x244) >>> [] (mmc_blk_issue_rw_rq+0x64/0x244) from [] (mmc_blk_issue_rq+0x2ac/0x2cc) >>> [] (mmc_blk_issue_rq+0x2ac/0x2cc) from [] (mmc_queue_thread+0x8c/0xf8) >>> [] (mmc_queue_thread+0x8c/0xf8) from [] (kthread+0x84/0x8c) >>> [] (kthread+0x84/0x8c) from [] (kernel_thread_exit+0x0/0x8) >>> ---[ end trace 5dec1c8d7857375d ]--- >>> >>> Signed-off-by: Felipe Contreras >>> --- >>> drivers/staging/tidspbridge/Kconfig | 1 + >>> 1 files changed, 1 insertions(+), 0 deletions(-) >>> >>> diff --git a/drivers/staging/tidspbridge/Kconfig b/drivers/staging/tidspbridge/Kconfig >>> index 21a559e..614e974 100644 >>> --- a/drivers/staging/tidspbridge/Kconfig >>> +++ b/drivers/staging/tidspbridge/Kconfig >>> @@ -61,6 +61,7 @@ config TIDSPBRIDGE_CACHE_LINE_CHECK >>> config TIDSPBRIDGE_WDT3 >>> bool "Enable watchdog timer" >>> depends on TIDSPBRIDGE >>> + default y >> >> Nothing is ever default y, sorry, I can't accept this. > > % git grep 'default y' -- 'drivers/*/Kconfig' | wc -l > 493 > not sure if I see this warning or not on my machine, but is there a fix for the warning? I would rather see that, than hide it with setting: default y (if that's what its doing!) Justin P. Mattock