From: Rajendra Nayak <rnayak@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: OMAP: Get rid of reset for system timer
Date: Tue, 14 Feb 2012 10:44:56 +0530 [thread overview]
Message-ID: <4F39EDD0.9010304@ti.com> (raw)
In-Reply-To: <20120210191813.GU1426@atomide.com>
On Saturday 11 February 2012 12:48 AM, Tony Lindgren wrote:
> * Santosh Shilimkar<santosh.shilimkar@ti.com> [120202 05:33]:
>> > From: Rajendra Nayak<rnayak@ti.com>
>> >
>> > hwmod setup already does a reset and sets the OCP sysconfig
>> > registers appropriately. Avoid doing a reset again and overriding
>> > the OCP sysconfig settings in the system timer init code.
>
> If we want this queued as a fix, it should also describe what
> actually breaks? Timer? PM?
It only fixes the redundant reset and overriding the smartidle-wakeup
OCP setting (done by hwmod) with the smartidle in the driver.
Doing this doesn't really break anything as yet in mainline, but will
cause timer wakeup issues once OFF mode is in place for OMAP4. On OMAP5
however this was causing more issues as the softreset bit position is
different than on OMAP2/3/4.
So it should be ok to queue this in for 3.4 considering neither OMAP4
OFF, not OMAP5 support is in mainline yet.
next prev parent reply other threads:[~2012-02-14 5:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 14:03 [PATCH 0/2] ARM: OMAP: Couple of misc fixes for 3.3 Santosh Shilimkar
2012-02-02 14:03 ` [PATCH 1/2] ARM: OMAP: Get rid of reset for system timer Santosh Shilimkar
2012-02-02 18:40 ` Kevin Hilman
2012-02-03 7:15 ` Shilimkar, Santosh
2012-02-03 17:54 ` Kevin Hilman
2012-02-10 19:18 ` Tony Lindgren
2012-02-14 5:14 ` Rajendra Nayak [this message]
2012-02-14 7:15 ` Shilimkar, Santosh
2012-02-14 19:19 ` Tony Lindgren
2012-02-02 14:03 ` [PATCH 2/2] ARM: OMAP4: Move the barrier memboclk_steal() as part of reserve callback Santosh Shilimkar
2012-02-10 19:19 ` Tony Lindgren
2012-02-14 8:49 ` Santosh Shilimkar
2012-02-14 11:14 ` Russell King - ARM Linux
2012-02-14 11:29 ` Shilimkar, Santosh
2012-02-14 19:18 ` Tony Lindgren
2012-02-14 11:13 ` Russell King - ARM Linux
2012-02-06 9:33 ` [PATCH 0/2] ARM: OMAP: Couple of misc fixes for 3.3 Shilimkar, Santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F39EDD0.9010304@ti.com \
--to=rnayak@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).