From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajendra Nayak Subject: Re: [PATCH v2 0/6] mmc: omap_hsmmc: Clean up use/abuse of pdev->id Date: Fri, 24 Feb 2012 15:40:48 +0530 Message-ID: <4F476228.7060607@ti.com> References: <1329996409-26861-1-git-send-email-rnayak@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from na3sys009aog103.obsmtp.com ([74.125.149.71]:46461 "EHLO na3sys009aog103.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751644Ab2BXKK4 (ORCPT ); Fri, 24 Feb 2012 05:10:56 -0500 Received: by mail-gy0-f170.google.com with SMTP id g2so643407ghb.1 for ; Fri, 24 Feb 2012 02:10:55 -0800 (PST) In-Reply-To: <1329996409-26861-1-git-send-email-rnayak@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Rajendra Nayak Cc: linux-mmc@vger.kernel.org, cjb@laptop.org, linux-omap@vger.kernel.org, balajitk@ti.com, svenkatr@ti.com, linux-arm-kernel@lists.infradead.org, linaro-dev@lists.linaro.org, patches@linaro.org Chris, On Thursday 23 February 2012 04:56 PM, Rajendra Nayak wrote: > Re-sending as these patches did not make it to the lists due to > issues with my 'git send-email' > > This series mainly cleans up all instances of hardcoding's in > the driver based on pdev->id. This is cleanup leading to the > DT adaptation of omap_hsmmc driver. > > v2 mainly has some minor changes to get rid of a debug print > which was still using host->id and getting rid of 'id' field > entirely from omap_hsmmc_host struct. > > The series is tested on OMAP4SDP, OMAP4panda, OMAP3beagle and OMAP2430SDP > boards. This series is reviewed/tested and acked by Balaji and Venkat. Care to pull this in for 3.4? I have one other cleanup patch on top of this series to make all remaining pr_* prints in the driver to dev_* [1]. It would be great if you could pick that up as well. These patches are cleanups leading to the DT conversion of omap_hsmmc driver. regards, Rajendra [1] http://marc.info/?l=linux-mmc&m=132999677405098&w=3 > > regards, > Rajendra > > Balaji T K (3): > mmc: omap_hsmmc: use platform_get_resource_byname for tx/rx DMA > channels > mmc: omap_hsmmc: remove unused .set_sleep function > mmc: omap_hsmmc: Use OMAP_HSMMC_SUPPORTS_DUAL_VOLT flag to remove > host->id based hardcoding > > Rajendra Nayak (3): > mmc: omap_hsmmc: Get rid of omap_hsmmc_1_set_power function > mmc: omap_hsmmc: Get rid of omap_hsmmc_4_set_power function > mmc: omap_hsmmc: Don't expect MMC1 to always have vmmc supply > > arch/arm/plat-omap/include/plat/mmc.h | 2 - > drivers/mmc/host/omap_hsmmc.c | 175 +++------------------------------ > 2 files changed, 16 insertions(+), 161 deletions(-) >