From: Adrian Hunter <adrian.hunter@intel.com>
To: Sujit Reddy Thumma <sthumma@codeaurora.org>
Cc: Chris Ball <cjb@laptop.org>,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org, Rajendra Nayak <rnayak@ti.com>,
Venkatraman S <svenkatr@ti.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Thomas Abraham <thomas.abraham@linaro.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@ti.com>
Subject: Re: [PATCH] mmc: start removing enable / disable API
Date: Wed, 29 Feb 2012 09:15:48 +0200 [thread overview]
Message-ID: <4F4DD0A4.2080802@intel.com> (raw)
In-Reply-To: <4F4DC59D.70903@codeaurora.org>
On 29/02/12 08:28, Sujit Reddy Thumma wrote:
> Hi Adrian,
>
> On 2/24/2012 4:19 PM, Adrian Hunter wrote:
>> Most parts of the enable / disable API are no longer used and
>> can be removed.
>>
>> Cc: Rajendra Nayak<rnayak@ti.com>
>> Cc: Venkatraman S<svenkatr@ti.com>
>> Cc: Kukjin Kim<kgene.kim@samsung.com>
>> Cc: Thomas Abraham<thomas.abraham@linaro.org>
>> Cc: Kyungmin Park<kyungmin.park@samsung.com>
>> Cc: Sekhar Nori<nsekhar@ti.com>
>> Cc: Kevin Hilman<khilman@ti.com>
>> Signed-off-by: Adrian Hunter<adrian.hunter@intel.com>
>> ---
>> arch/arm/mach-exynos/mach-nuri.c | 5 +-
>> arch/arm/mach-exynos/mach-universal_c210.c | 9 +-
>> drivers/mmc/core/core.c | 185
>> ++--------------------------
>> drivers/mmc/core/host.c | 1 -
>> drivers/mmc/core/host.h | 1 -
>> drivers/mmc/host/davinci_mmc.c | 4 -
>> drivers/mmc/host/omap_hsmmc.c | 15 +--
>> include/linux/mmc/core.h | 1 -
>> include/linux/mmc/host.h | 46 +-------
>> 9 files changed, 25 insertions(+), 242 deletions(-)
>>
>
>> - if (host->caps& MMC_CAP_DISABLE)
>> - cancel_delayed_work(&host->disable);
>> cancel_delayed_work_sync(&host->detect);
>> mmc_flush_scheduled_work();
>>
>> @@ -2402,13 +2245,11 @@ int mmc_suspend_host(struct mmc_host *host)
>> {
>> int err = 0;
>>
>> - if (host->caps& MMC_CAP_DISABLE)
>> - cancel_delayed_work(&host->disable);
>> cancel_delayed_work(&host->detect);
>> mmc_flush_scheduled_work();
>> if (mmc_try_claim_host(host)) {
>> err = mmc_cache_ctrl(host, 0);
>> - mmc_do_release_host(host);
>> + mmc_release_host(host);
>
> mmc_try_claim_host does not call host->ops->enable(), but mmc_release_host
> call host->ops->disable(), is there any reason for this?
No, it is an oversight. I will send V2.
prev parent reply other threads:[~2012-02-29 7:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 10:49 [PATCH] mmc: start removing enable / disable API Adrian Hunter
2012-02-29 6:28 ` Sujit Reddy Thumma
2012-02-29 7:15 ` Adrian Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4DD0A4.2080802@intel.com \
--to=adrian.hunter@intel.com \
--cc=cjb@laptop.org \
--cc=kgene.kim@samsung.com \
--cc=khilman@ti.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=rnayak@ti.com \
--cc=sthumma@codeaurora.org \
--cc=svenkatr@ti.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).