From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH v3 11/13] gpio/omap: fix dataout register overwrite in _set_gpio_dataout_* Date: Wed, 07 Mar 2012 13:04:34 +0100 Message-ID: <4F574ED2.4020102@ti.com> References: <1331118963-26364-1-git-send-email-tarun.kanti@ti.com> <1331118963-26364-12-git-send-email-tarun.kanti@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1331118963-26364-12-git-send-email-tarun.kanti@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Tarun Kanti DebBarma Cc: khilman@ti.com, tony@atomide.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org On Wednesday 07 March 2012 12:16 PM, Tarun Kanti DebBarma wrote: > In the existing _set_gpio_dataout_*() implementation, the dataout > register is overwritten every time the function is called. This is > not intended behavior because that would end up one user of a GPIO > line overwriting what is written by another. Fix this so that previous > value is always preserved until explicitly changed by respective > user/driver of the GPIO line. > > Signed-off-by: Tarun Kanti DebBarma > --- This can also go as fix. Reviewed-by: Santosh Shilimkar Regards Santosh