From: Henry Chan <enli.chan@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: Incorrect Register Offsets in OMAP Mailbox
Date: Thu, 08 Mar 2012 00:04:58 -0800 [thread overview]
Message-ID: <4F58682A.7010908@gmail.com> (raw)
In-Reply-To: <20120305193417.GL12083@atomide.com>
Sorry about that. Kind of new at this.
-H
Signed-off-by: Henry Chan <enli.chan@gmail.com>
On 03/05/12 11:34, Tony Lindgren wrote:
> Hi Henry,
>
> * Henry Chan <enli.chan@gmail.com> [120207 09:25]:
>> Hi,
>>
>> Looks like the register offsets are incorrect in the OMAP mailbox code
>> (arch/arm/mach-omap2/mailbox.c) for the OMAP4_MAILBOX_IRQ* macros. The
>> discrepancy is with p.224 of TI document SPRUGX9 and p3891 of SWPU231K.
>> Patch attached.
>>
>> My hardware hasn't come in yet, so I would appreciate it if anyone can
>> share their experience using this code.
>
> Can you please reply with your Signed-off-by, it's missing from the
> patch.
>
> Thanks,
>
> Tony
>
>> --- a/arch/arm/mach-omap2/mailbox.c
>> +++ b/arch/arm/mach-omap2/mailbox.c
>> @@ -26,9 +26,9 @@
>> #define MAILBOX_IRQSTATUS(u) (0x100 + 8 * (u))
>> #define MAILBOX_IRQENABLE(u) (0x104 + 8 * (u))
>>
>> -#define OMAP4_MAILBOX_IRQSTATUS(u) (0x104 + 10 * (u))
>> -#define OMAP4_MAILBOX_IRQENABLE(u) (0x108 + 10 * (u))
>> -#define OMAP4_MAILBOX_IRQENABLE_CLR(u) (0x10c + 10 * (u))
>> +#define OMAP4_MAILBOX_IRQSTATUS(u) (0x104 + 0x10 * (u))
>> +#define OMAP4_MAILBOX_IRQENABLE(u) (0x108 + 0x10 * (u))
>> +#define OMAP4_MAILBOX_IRQENABLE_CLR(u) (0x10c + 0x10 * (u))
>>
>> #define MAILBOX_IRQ_NEWMSG(m) (1 << (2 * (m)))
>> #define MAILBOX_IRQ_NOTFULL(m) (1 << (2 * (m) + 1))
>>
>
--
Henry Chan
next prev parent reply other threads:[~2012-03-08 8:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 17:57 Incorrect Register Offsets in OMAP Mailbox Henry Chan
2012-03-05 19:34 ` Tony Lindgren
2012-03-08 8:04 ` Henry Chan [this message]
2012-05-04 18:07 ` Tony Lindgren
[not found] <331ABD5ECB02734CA317220B2BBEABC1317897C8@DBDE01.ent.ti.com>
2012-02-09 11:25 ` Bedia, Vaibhav
2012-02-09 17:47 ` Tony Lindgren
2012-02-09 17:58 ` Bedia, Vaibhav
2012-02-10 1:14 ` Tony Lindgren
2012-02-10 4:25 ` Bedia, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F58682A.7010908@gmail.com \
--to=enli.chan@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).