From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shubhrajyoti Subject: Re: [PATCH RESEND 4/8] mmc: omap: context save after enabling runtime pm Date: Thu, 15 Mar 2012 20:42:42 +0530 Message-ID: <4F6206EA.9060104@ti.com> References: <1331822022-26714-1-git-send-email-svenkatr@ti.com> <1331822022-26714-5-git-send-email-svenkatr@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from na3sys009aog125.obsmtp.com ([74.125.149.153]:56589 "EHLO na3sys009aog125.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965275Ab2COPMu (ORCPT ); Thu, 15 Mar 2012 11:12:50 -0400 Received: by mail-ob0-f178.google.com with SMTP id uo19so73371obb.9 for ; Thu, 15 Mar 2012 08:12:48 -0700 (PDT) In-Reply-To: <1331822022-26714-5-git-send-email-svenkatr@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Venkatraman S Cc: linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org, cjb@laptop.org, balajitk@ti.com, balbi@ti.com On Thursday 15 March 2012 08:03 PM, Venkatraman S wrote: > From: Balaji T K > > call context save api after enabling runtime pm > to make sure register access in context save api If I am not mistaken the api would store the number of power state changes and accesses no registers. Am I missing something? > happens with clk enabled. > > Signed-off-by: Balaji T K > --- > drivers/mmc/host/omap_hsmmc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index 0f8d34b..9fa2f39 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -1871,8 +1871,6 @@ static int __init omap_hsmmc_probe(struct platform_device *pdev) > goto err1; > } > > - omap_hsmmc_context_save(host); > - > if (host->pdata->controller_flags & OMAP_HSMMC_BROKEN_MULTIBLOCK_READ) { > dev_info(&pdev->dev, "multiblock reads disabled due to 35xx erratum 2.1.1.128; MMC read performance may suffer\n"); > mmc->caps2 |= MMC_CAP2_NO_MULTI_READ; > @@ -1883,6 +1881,8 @@ static int __init omap_hsmmc_probe(struct platform_device *pdev) > pm_runtime_set_autosuspend_delay(host->dev, MMC_AUTOSUSPEND_DELAY); > pm_runtime_use_autosuspend(host->dev); > > + omap_hsmmc_context_save(host); > + > if (cpu_is_omap2430()) { > host->dbclk = clk_get(&pdev->dev, "mmchsdb_fck"); > /*