Re: [PATCH 2/5 RESEND] ARM: OMAP: USB: Build the USB HOST TLL omap device

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello.

On 19-03-2012 10:48, Keshava Munegowda wrote:

> From: Keshava Munegowda<Keshava_mgowda@ti.com>

> The hwmod of the usb tll is retrieved and omap device build is
> performed to created the platform device for the usb tll component.

> Signed-off-by: Keshava Munegowda<keshava_mgowda@ti.com>
> Reviewed-by: Partha Basak<parthab@india.ti.com>
> ---
>   arch/arm/mach-omap2/usb-host.c |   28 ++++++++++++++++++++--------
>   1 files changed, 20 insertions(+), 8 deletions(-)

> diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c
> index f51348d..dc6769a 100644
> --- a/arch/arm/mach-omap2/usb-host.c
> +++ b/arch/arm/mach-omap2/usb-host.c
[...]
> @@ -510,25 +512,35 @@ void __init usbhs_init(const struct usbhs_omap_board_data *pdata)
[...]
> -	pdev = omap_device_build_ss(OMAP_USBHS_DEVICE, bus_id, oh, 2,
> +	pdev = omap_device_build(OMAP_USBTLL_DEVICE, bus_id, tll_hwm,
> +				(void *)&usbtll_data, sizeof(usbtll_data),

    There's no need to explicitly cast to 'void *'. The cast is automatic.

> +				omap_uhhtll_latency,
> +				ARRAY_SIZE(omap_uhhtll_latency), false);
> +	if (IS_ERR(pdev)) {
> +		pr_err("Could not build hwmod device %s\n",
> +			USBHS_TLL_HWMODNAME);
> +		return;
> +	}
> +
> +	pdev = omap_device_build(OMAP_USBHS_DEVICE, bus_id, uhh_hwm,
>   				(void *)&usbhs_data, sizeof(usbhs_data),

    Same here.

WBR, Sergei