From: Sergei Shtylyov <sshtylyov@mvista.com>
To: balbi@ti.com
Cc: Keshava Munegowda <keshava_mgowda@ti.com>,
linux-omap@vger.kernel.org, linux-usb@vger.kernel.org,
sameo@linux.intel.com, parthab@india.ti.com,
govindraj.raja@ti.com, paul@pwsan.com, b-cousson@ti.com
Subject: Re: [PATCH 1/5 RESEND] ARM: OMAP: USB: HOST TLL platform driver
Date: Mon, 19 Mar 2012 15:09:12 +0400 [thread overview]
Message-ID: <4F6713D8.3080206@mvista.com> (raw)
In-Reply-To: <20120319100603.GB20279@arwen.pp.htv.fi>
Hello.
On 19-03-2012 14:06, Felipe Balbi wrote:
>> + ver = usbtll_read(base, OMAP_USBTLL_REVISION);
>> + if (ver == OMAP_USBTLL_REV1)
>> + count = OMAP_TLL_CHANNEL_COUNT;
>> + else if (ver == OMAP_USBTLL_REV2)
>> + count = OMAP_REV2_TLL_CHANNEL_COUNT;
>> + else {
>> + dev_err(dev, "TLL version failed\n");
>> + ret = -ENODEV;
>> + goto err_ioremap;
>> + }
> wrong coding style.
And *switch* seems more fitting here.
WBR, Sergei
next prev parent reply other threads:[~2012-03-19 11:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 6:48 [PATCH 0/5 RESEND] ARM: OMAP: TLL driver implementation for USB host driver Keshava Munegowda
2012-03-19 6:48 ` [PATCH 1/5 RESEND] ARM: OMAP: USB: HOST TLL platform driver Keshava Munegowda
2012-03-19 6:48 ` [PATCH 2/5 RESEND] ARM: OMAP: USB: Build the USB HOST TLL omap device Keshava Munegowda
[not found] ` <1332139715-1495-3-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2012-03-19 6:48 ` [PATCH 3/5 RESEND] ARM: OMAP: USB: Remove TLL specific code Keshava Munegowda
[not found] ` <1332139715-1495-4-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2012-03-19 6:48 ` [PATCH 4/5 RESEND] ARM: OMAP: USB: Invoke the TLL driver from USB HS core driver Keshava Munegowda
[not found] ` <1332139715-1495-5-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2012-03-19 6:48 ` [PATCH 5/5 RESEND] ARM: OMAP: change the USB TLL clocks device name Keshava Munegowda
2012-03-19 10:59 ` [PATCH 4/5 RESEND] ARM: OMAP: USB: Invoke the TLL driver from USB HS core driver Sergei Shtylyov
2012-03-19 10:53 ` [PATCH 2/5 RESEND] ARM: OMAP: USB: Build the USB HOST TLL omap device Sergei Shtylyov
2012-03-19 9:41 ` [PATCH 1/5 RESEND] ARM: OMAP: USB: HOST TLL platform driver Shubhrajyoti
[not found] ` <4F66FF47.7000800-l0cyMroinI0@public.gmane.org>
2012-03-20 7:28 ` Munegowda, Keshava
[not found] ` <CAP05o4+A7AZ0SmMLgCfbBHs+zhsN-c2zM8caYe8M3-OC3YmZzg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-20 8:52 ` Shubhrajyoti
2012-03-20 9:15 ` Munegowda, Keshava
2012-03-19 10:06 ` Felipe Balbi
2012-03-19 11:09 ` Sergei Shtylyov [this message]
[not found] ` <4F6713D8.3080206-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
2012-03-20 7:25 ` Munegowda, Keshava
2012-03-20 9:30 ` Munegowda, Keshava
[not found] ` <CAP05o4LkWpANqibBXsY-FbCTOsioUq4qPdA8k=Ct4HHGYfL4Ng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-20 9:59 ` Felipe Balbi
[not found] ` <20120320095914.GE9157-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-03-20 10:51 ` Munegowda, Keshava
2012-03-20 11:01 ` Felipe Balbi
2012-03-20 7:32 ` Munegowda, Keshava
2012-03-20 10:01 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6713D8.3080206@mvista.com \
--to=sshtylyov@mvista.com \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=govindraj.raja@ti.com \
--cc=keshava_mgowda@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=parthab@india.ti.com \
--cc=paul@pwsan.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox