From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup Date: Wed, 21 Mar 2012 15:19:15 +0100 Message-ID: <4F69E363.4020709@linaro.org> References: <1332322070-24577-1-git-send-email-daniel.lezcano@linaro.org> <4F69A872.50203@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ee0-f46.google.com ([74.125.83.46]:47638 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030828Ab2CUOTT (ORCPT ); Wed, 21 Mar 2012 10:19:19 -0400 Received: by eekc41 with SMTP id c41so385267eek.19 for ; Wed, 21 Mar 2012 07:19:17 -0700 (PDT) In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Jean Pihet Cc: Santosh Shilimkar , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linaro Dev On 03/21/2012 02:43 PM, Jean Pihet wrote: > On Wed, Mar 21, 2012 at 11:07 AM, Santosh Shilimkar > wrote: >> Daniel, >> >> On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote: >>> This patchset is a proposition to improve a bit the code. >>> The changes are code cleanup and does not change the behavior of th= e >>> driver itself. >>> >>> A couple a things call my intention. Why the cpuidle device is set = for cpu0 only >>> and why the WFI is not used ? >>> >>> Daniel Lezcano (7): >>> ARM: OMAP4: cpuidle - Remove unused valid field >>> ARM: OMAP4: cpuidle - Declare the states with the driver declara= tion >>> ARM: OMAP4: cpuidle - Remove the cpuidle_params_table table >>> ARM: OMAP4: cpuidle - fix static omap4_idle_data declaration >>> ARM: OMAP4: cpuidle - Initialize omap4_idle_data at compile time >>> ARM: OMAP4: cpuidle - use the omap4_idle_data variable directly >>> ARM: OMAP4: cpuidle - remove omap4_idle_data initialization at b= oot >>> time >>> >> The series looks fine to me in general. This clean-up is applicable >> for OMAP3 cpuidle code as well. > Great! > However OMAP3 has a few specific things that cannot be removed as eas= ily: > - the 'valid' flag is used because only certain combinations of power > domains states are possible, > - the latency settings can be overriden by the board code, so the > cpuidle_params struct is needed. Right, I noticed that. I am looking for a way to have a similar cleanup= =20 for omap3 but without breaking the rx51 board. Thanks -- Daniel >> I want Jean to look at this series because some of his earlier >> clean up has introduced those custom functions which >> are getting removed in this series. >> >> Regards >> santosh >> >> > > Thanks, > Jean --=20 Linaro.org =E2=94=82 Open source software fo= r ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html