From: Shubhrajyoti <shubhrajyoti@ti.com>
To: balbi@ti.com
Cc: Sergei Shtylyov <sshtylyov@mvista.com>,
linux-omap@vger.kernel.org, linux-usb@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH RFC] usb: musb: omap: fix the error check for pm_runtime_get_sync
Date: Thu, 22 Mar 2012 19:06:11 +0530 [thread overview]
Message-ID: <4F6B2ACB.60302@ti.com> (raw)
In-Reply-To: <20120322125550.GG32368@arwen.pp.htv.fi>
>> You haven't run it thru scripts/checkpatch.pl either, I guess?
>>
Actually modified the patch a little afterwards.
>>> drivers/usb/musb/omap2430.c | 5 +++--
>>> 1 files changed, 3 insertions(+), 2 deletions(-)
>>> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
>>> index 2ae0bb3..e5dd18f 100644
>>> --- a/drivers/usb/musb/omap2430.c
>>> +++ b/drivers/usb/musb/omap2430.c
>> [...]
>>> @@ -301,7 +302,7 @@ static int omap2430_musb_init(struct musb *musb)
>>>
>>> status = pm_runtime_get_sync(dev);
>>> if (status< 0) {
>>> - dev_err(dev, "pm_runtime_get_sync FAILED");
>>> + dev_err(dev, "pm_runtime_get_sync FAILED %d \n",status);
>> If I don't mistake, scripts/checkpatch.pl should warn about
>> unneeded spaces before '\n'. And also about missing spaces after
>> commas.
> I fixed in my branch, thanks
>
Thanks Felipe,
Anyways resent the patch.
prev parent reply other threads:[~2012-03-22 13:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 7:18 [PATCH RFC] usb: musb: omap: fix the error check for pm_runtime_get_sync Shubhrajyoti D
[not found] ` <1332400686-27674-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-03-22 8:09 ` Felipe Balbi
2012-03-22 12:42 ` Sergei Shtylyov
[not found] ` <4F6B1E2D.8020802-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
2012-03-22 12:55 ` Felipe Balbi
2012-03-22 13:36 ` Shubhrajyoti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6B2ACB.60302@ti.com \
--to=shubhrajyoti@ti.com \
--cc=balbi@ti.com \
--cc=kishon@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox