From: Igor Grinberg <grinberg@compulab.co.il>
To: Russ Dill <Russ.Dill@ti.com>
Cc: linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Matt Porter <mporter@ti.com>,
robert.marklund@stericsson.com, linus.walleij@linaro.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 05/12] Add dummy smsc911x regulators to cm-t35.
Date: Tue, 27 Mar 2012 17:53:52 +0200 [thread overview]
Message-ID: <4F71E290.2050403@compulab.co.il> (raw)
In-Reply-To: <1332494504-10251-6-git-send-email-Russ.Dill@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1467 bytes --]
Hi Russ,
This patch works, but can we, please use the attached patch instead?
Thanks
On 03/23/12 11:21, Russ Dill wrote:
> Signed-off-by: Russ Dill <russ.dill@ti.com>
> ---
> arch/arm/mach-omap2/board-cm-t35.c | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c
> index 41b0a2f..289ded3 100644
> --- a/arch/arm/mach-omap2/board-cm-t35.c
> +++ b/arch/arm/mach-omap2/board-cm-t35.c
> @@ -26,6 +26,7 @@
>
> #include <linux/i2c/at24.h>
> #include <linux/i2c/twl.h>
> +#include <linux/regulator/fixed.h>
> #include <linux/regulator/machine.h>
> #include <linux/mmc/host.h>
>
> @@ -630,10 +631,18 @@ static inline void cm_t3730_init_mux(void) {}
> static struct omap_board_config_kernel cm_t35_config[] __initdata = {
> };
>
> +static struct regulator_consumer_supply dummy_supplies[] = {
> + REGULATOR_SUPPLY("vddvario", "smsc911x.0"),
> + REGULATOR_SUPPLY("vdd33a", "smsc911x.0"),
> + REGULATOR_SUPPLY("vddvario", "smsc911x.1"),
> + REGULATOR_SUPPLY("vdd33a", "smsc911x.1"),
> +};
> +
> static void __init cm_t3x_common_init(void)
> {
> omap_board_config = cm_t35_config;
> omap_board_config_size = ARRAY_SIZE(cm_t35_config);
> + regulator_register_fixed(0, dummy_supplies, ARRAY_SIZE(dummy_supplies));
> omap3_mux_init(board_mux, OMAP_PACKAGE_CUS);
> omap_serial_init();
> omap_sdrc_init(mt46h32m32lf6_sdrc_params,
--
Regards,
Igor.
[-- Attachment #2: 0001-ARM-OMAP3-cm-t35-add-smsc911x-regulators.patch --]
[-- Type: text/x-patch, Size: 1711 bytes --]
>From 0e1bbe7634edbbb75493a7a6257db94621c1efab Mon Sep 17 00:00:00 2001
From: Igor Grinberg <grinberg@compulab.co.il>
Date: Fri, 23 Mar 2012 02:21:37 -0700
Subject: [PATCH] ARM: OMAP3: cm-t35: add smsc911x regulators
Add dummy regulators for smsc911x Ethernet controllers on both
cm-t35/cmt3730 and sb-t35 boards.
Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
---
arch/arm/mach-omap2/board-cm-t35.c | 16 ++++++++++++++++
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c
index d73316e..8770be1 100644
--- a/arch/arm/mach-omap2/board-cm-t35.c
+++ b/arch/arm/mach-omap2/board-cm-t35.c
@@ -26,6 +26,7 @@
#include <linux/i2c/at24.h>
#include <linux/i2c/twl.h>
+#include <linux/regulator/fixed.h>
#include <linux/regulator/machine.h>
#include <linux/mmc/host.h>
@@ -81,8 +82,23 @@ static struct omap_smsc911x_platform_data sb_t35_smsc911x_cfg = {
.flags = SMSC911X_USE_32BIT | SMSC911X_SAVE_MAC_ADDRESS,
};
+static struct regulator_consumer_supply cm_t35_smsc911x_supplies[] = {
+ REGULATOR_SUPPLY("vddvario", "smsc911x.0"),
+ REGULATOR_SUPPLY("vdd33a", "smsc911x.0"),
+};
+
+static struct regulator_consumer_supply sb_t35_smsc911x_supplies[] = {
+ REGULATOR_SUPPLY("vddvario", "smsc911x.1"),
+ REGULATOR_SUPPLY("vdd33a", "smsc911x.1"),
+};
+
static void __init cm_t35_init_ethernet(void)
{
+ regulator_register_fixed(0, cm_t35_smsc911x_supplies,
+ ARRAY_SIZE(cm_t35_smsc911x_supplies));
+ regulator_register_fixed(1, sb_t35_smsc911x_supplies,
+ ARRAY_SIZE(sb_t35_smsc911x_supplies));
+
gpmc_smsc911x_init(&cm_t35_smsc911x_cfg);
gpmc_smsc911x_init(&sb_t35_smsc911x_cfg);
}
--
1.7.3.4
next prev parent reply other threads:[~2012-03-27 15:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 9:21 [PATCH v2 00/12] Fixup gmpc smsc911x regulator handling Russ Dill
2012-03-23 9:21 ` [PATCH 01/12] Remove odd gpmc_cfg/board_data redirection Russ Dill
2012-03-27 15:45 ` Igor Grinberg
2012-03-23 9:21 ` [PATCH 02/12] Fix possible stale smsc911x flags Russ Dill
2012-03-27 15:47 ` Igor Grinberg
2012-03-23 9:21 ` [PATCH 03/12] Remove unused rate calculation Russ Dill
2012-03-23 9:21 ` [PATCH 04/12] Remove regulator support from gmpc-smsc911x Russ Dill
2012-03-27 15:46 ` Igor Grinberg
2012-03-23 9:21 ` [PATCH 05/12] Add dummy smsc911x regulators to cm-t35 Russ Dill
2012-03-27 15:53 ` Igor Grinberg [this message]
2012-03-27 17:28 ` Tony Lindgren
2012-03-28 6:33 ` Igor Grinberg
2012-03-28 17:03 ` Tony Lindgren
2012-03-30 15:23 ` Igor Grinberg
2012-04-03 17:26 ` Tony Lindgren
2012-03-27 18:32 ` Russ Dill
2012-03-28 6:34 ` Igor Grinberg
2012-04-03 17:43 ` Tony Lindgren
2012-04-05 7:34 ` Igor Grinberg
2012-03-23 9:21 ` [PATCH 06/12] Add dummy smsc911x regulators to igep0020 Russ Dill
2012-03-23 9:21 ` [PATCH 07/12] Add dummy smsc911x regulators to ldp Russ Dill
2012-03-23 9:21 ` [PATCH 08/12] Add dummy smsc911x regulators to omap3evm Russ Dill
2012-03-23 9:21 ` [PATCH 09/12] Add dummy smsc911x regulators to omap3logic Russ Dill
2012-03-23 9:21 ` [PATCH 10/12] Add dummy smsc911x regulators to omap3stalker Russ Dill
2012-03-23 9:21 ` [PATCH 11/12] Add dummy smsc911x regulators to overo Russ Dill
2012-03-23 9:21 ` [PATCH 12/12] Add dummy smsc911x regulators to zoom-debugboard Russ Dill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F71E290.2050403@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=Russ.Dill@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mporter@ti.com \
--cc=robert.marklund@stericsson.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).