From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH 02/17][V2] ARM: OMAP4: cpuidle - Declare the states with the driver declaration Date: Mon, 23 Apr 2012 16:06:47 +0200 Message-ID: <4F9561F7.3000306@linaro.org> References: <1333570371-1389-1-git-send-email-daniel.lezcano@linaro.org> <1333570371-1389-3-git-send-email-daniel.lezcano@linaro.org> <87vcl8a5wb.fsf@ti.com> <4F901A03.9080000@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:34725 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754469Ab2DWOGu (ORCPT ); Mon, 23 Apr 2012 10:06:50 -0400 Received: by bkcik5 with SMTP id ik5so8649730bkc.19 for ; Mon, 23 Apr 2012 07:06:49 -0700 (PDT) In-Reply-To: <4F901A03.9080000@linaro.org> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kevin Hilman Cc: linaro-dev@lists.linaro.org, patches@linaro.org, tony@atomide.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org On 04/19/2012 03:58 PM, Daniel Lezcano wrote: > On 04/10/2012 12:37 AM, Kevin Hilman wrote: >> Daniel Lezcano writes: >> >>> The cpuidle API allows to declare statically the states in the driv= er >>> structure. Let's use it. >>> We do no longer need the fill_cstate function called at runtime and >>> by the way adding more instructions at boot time. >>> >>> Signed-off-by: Daniel Lezcano >>> Reviewed-by: Jean Pihet >>> Reviewed-by: Santosh Shilimkar >>> --- >>> arch/arm/mach-omap2/cpuidle44xx.c | 57=20 >>> +++++++++++++++++++++--------------- >>> 1 files changed, 33 insertions(+), 24 deletions(-) >>> >>> diff --git a/arch/arm/mach-omap2/cpuidle44xx.c=20 >>> b/arch/arm/mach-omap2/cpuidle44xx.c >>> index ee0bc50..6d86b59 100644 >>> --- a/arch/arm/mach-omap2/cpuidle44xx.c >>> +++ b/arch/arm/mach-omap2/cpuidle44xx.c >>> @@ -132,21 +132,39 @@ struct cpuidle_driver omap4_idle_driver =3D { >>> .name =3D "omap4_idle", >>> .owner =3D THIS_MODULE, >>> .en_core_tk_irqen =3D 1, >>> + .states =3D { >>> + { >>> + /* C1 - CPU0 ON + CPU1 ON + MPU ON */ >>> + .exit_latency =3D 2 + 2, >>> + .target_residency =3D 5, >>> + .flags =3D CPUIDLE_FLAG_TIME_VALID, >>> + .enter =3D omap4_enter_idle, >>> + .name =3D "C1", >>> + .desc =3D "MPUSS ON" >>> + }, >>> + { >>> + /* C2 - CPU0 OFF + CPU1 OFF + MPU CSWR */ >>> + .exit_latency =3D 328 + 440, >>> + .target_residency =3D 960, >>> + .flags =3D CPUIDLE_FLAG_TIME_VALID, >>> + .enter =3D omap4_enter_idle, >>> + .name =3D "C2", >>> + .desc =3D "MPUSS CSWR", >>> + }, >>> + { >>> + /* C3 - CPU0 OFF + CPU1 OFF + MPU OSWR */ >>> + .exit_latency =3D 460 + 518, >>> + .target_residency =3D 1100, >>> + .flags =3D CPUIDLE_FLAG_TIME_VALID, >>> + .enter =3D omap4_enter_idle, >>> + .name =3D "C3", >>> + .desc =3D "MPUSS OSWR", >>> + }, >>> + }, >>> + .state_count =3D OMAP4_NUM_STATES, >> >> I think you can drop OMAP4_NUM_STATES here, and just use: >> >> .state_count =3D ARRAY_SIZE(omap4_idle_driver.states), >> >> Then drop OMAP4_NUM_STATES all together in patch 3. > > Ok. I said 'ok' but it is not :) omap4_idle_driver.states has a fixed length which is CPUIDLE_STATE_MAX = (8). We need to define it manually as 3 for now. --=20 Linaro.org =E2=94=82 Open source software f= or ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html