From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kevin Hilman <khilman@ti.com>
Subject: Re: [PATCH-V4 3/3] ARM: OMAP: Make OMAP clocksource source selection
 using kernel param
Date: Thu, 26 Apr 2012 12:47:34 -0700
Message-ID: <4F99A656.9030800@ti.com>
References: <1335260749-25877-1-git-send-email-hvaibhav@ti.com> <1335260749-25877-4-git-send-email-hvaibhav@ti.com> <87aa1ybaxf.fsf@ti.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-omap-owner@vger.kernel.org>
Received: from na3sys009aog122.obsmtp.com ([74.125.149.147]:50991 "EHLO
	na3sys009aog122.obsmtp.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1758622Ab2DZTrf (ORCPT
	<rfc822;linux-omap@vger.kernel.org>);
	Thu, 26 Apr 2012 15:47:35 -0400
Received: by dacx6 with SMTP id x6so2193565dac.18
        for <linux-omap@vger.kernel.org>; Thu, 26 Apr 2012 12:47:34 -0700 (PDT)
In-Reply-To: <87aa1ybaxf.fsf@ti.com>
Sender: linux-omap-owner@vger.kernel.org
List-Id: linux-omap@vger.kernel.org
To: Kevin Hilman <khilman@ti.com>
Cc: Vaibhav Hiremath <hvaibhav@ti.com>, linux-omap@vger.kernel.org, tony@atomide.com, paul@pwsan.com, santosh.shilimkar@ti.com, b-cousson@ti.com, linux-arm-kernel@lists.infradead.org, Felipe Balbi <balbi@ti.com>, Tarun Kanti DebBarma <tarun.kanti@ti.com>, Ming Lei <tom.leiming@gmail.com>

On 04/26/2012 11:33 AM, Kevin Hilman wrote:
> Vaibhav Hiremath<hvaibhav@ti.com>  writes:
>
>> Current OMAP code supports couple of clocksource options based
>> on compilation flag (CONFIG_OMAP_32K_TIMER). The 32KHz sync-timer
>> and a gptimer which can run on 32KHz or system clock (e.g 38.4 MHz).
>
> [...]
>
>> +
>> +	sync32k_ick = clk_get(NULL, "omap_32ksync_ick");
>> +	if (!IS_ERR(sync32k_ick))
>> +		clk_enable(sync32k_ick);
>> +
>> +	sync32k_cnt_reg = base + OMAP2_32KSYNCNT_CR_OFF;
>> +
>> +	/*
>> +	 * 120000 rough estimate from the calculations in
>> +	 * __clocksource_updatefreq_scale.
>> +	 */
>> +	clocks_calc_mult_shift(&persistent_mult,&persistent_shift,
>> +			32768, NSEC_PER_SEC, 120000);
>> +
>> +	ret = clocksource_mmio_init(base, "32k_counter", 32768, 250, 32,
>> +				clocksource_mmio_readl_up);
>
> After discussing this a bit with Vaibhav offline, we found that 'base'
> here should be sync32k_cnt_reg.

Sorry, this was confusing.  To be more specific, s/base/sync32k_cnt_reg/ 
in the clocksource_mmio_init line
above.

Kevin

> Can you guys that were seeing the hang confirm that that fixes the
> issue?
>
> If so, please reply with your Tested-by.
>
> Thanks,
>
> Kevin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html