From: Kevin Hilman <khilman@deeprootsystems.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Kevin Hilman <khilman@ti.com>, Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, santosh.shilimkar@ti.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP2+: watchdog: fix !PM boot crash, disarm timer after hwmod reset
Date: Thu, 03 May 2012 11:19:52 -0700 [thread overview]
Message-ID: <4FA2CC48.8020302@deeprootsystems.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1204201451510.11306@utopia.booyaka.com>
Hi Paul,
On 04/20/2012 01:59 PM, Paul Walmsley wrote:
[...]
> This looks great, looks like it will finally fix this longstanding bug. I
> think Santosh hit it too a long time ago, so I suspect he will be happy
> too.
>
> One comment: I think that omap2_wd_timer_reset() needs to be updated in
> light of commit 3c55c1baffa5f719eb2ae9729088bc867f972f53 ("ARM: OMAP2+:
> hwmod: Revert "ARM: OMAP2+: hwmod: Make omap_hwmod_softreset wait for
> reset status""). I did this here. It's passed basic build testing but
> haven't tried booting it yet. Care to take a look and see if you have any
> comments? It's also available in the 'hwmod_devel_a_3.5' branch of
> git://git.pwsan.com/linux-2.6
I just noticed a compile warning with your updated version:
/work/kernel/omap/pm/arch/arm/mach-omap2/wd_timer.c: In function
'omap2_wd_timer_reset':
/work/kernel/omap/pm/arch/arm/mach-omap2/wd_timer.c:78:6: warning:
unused variable 'v' [-Wunused-variable]
The diff below on top of your patch fixes it.
Kevin
diff --git a/arch/arm/mach-omap2/wd_timer.c b/arch/arm/mach-omap2/wd_timer.c
index fcbb663..b2f1c67 100644
--- a/arch/arm/mach-omap2/wd_timer.c
+++ b/arch/arm/mach-omap2/wd_timer.c
@@ -75,7 +75,6 @@ int omap2_wd_timer_disable(struct omap_hwmod *oh)
*/
int omap2_wd_timer_reset(struct omap_hwmod *oh)
{
- u32 v;
int c = 0;
/* Write to the SOFTRESET bit */
next prev parent reply other threads:[~2012-05-03 18:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 21:51 [PATCH] ARM: OMAP2+: watchdog: fix !PM boot crash, disarm timer after hwmod reset Kevin Hilman
2012-04-20 20:59 ` Paul Walmsley
2012-04-23 17:42 ` Kevin Hilman
2012-04-24 6:09 ` Shilimkar, Santosh
2012-05-03 18:19 ` Kevin Hilman [this message]
2012-05-03 22:52 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA2CC48.8020302@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).