linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jon Hunter <jon-hunter@ti.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Paul Walmsley <paul@pwsan.com>, Kevin Hilman <khilman@ti.com>,
	Benoit Cousson <b-cousson@ti.com>,
	Ming Lei <ming.lei@canonical.com>,
	Maynard Johnson <maynardj@us.ibm.com>, "Shilimkar\\,
	Santosh" <santosh.shilimkar@ti.com>,
	"oprofile-list\\@lists.sourceforge.net"
	<oprofile-list@lists.sourceforge.net>,
	Lik Lik <lik88888@gmail.com>,
	"eranian\\@gmail.com" <eranian@gmail.com>,
	"linux-omap\\@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel\\@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: oprofile and ARM A9 hardware counter
Date: Fri, 4 May 2012 17:17:36 -0500	[thread overview]
Message-ID: <4FA45580.8070802@ti.com> (raw)
In-Reply-To: <20120426180719.GC20186@mudshark.cambridge.arm.com>

Hi Will,

On 04/26/2012 01:07 PM, Will Deacon wrote:
> On Wed, Apr 04, 2012 at 12:15:24PM +0100, Will Deacon wrote:
>> On Wed, Apr 04, 2012 at 12:29:49AM +0100, Paul Walmsley wrote:
>>>
>>> Part of the problem is that the clockdomain data for the emu_sys 
>>> clockdomain is wrong.  Here's something to try to fix it.  It might just 
>>> be enough to get it to work.
>>
>> Hmm, doesn't seem to work but I do see the following in dmesg when I try to
>> use perf:
>>
>>  powerdomain: waited too long for powerdomain emu_pwrdm to complete transition
>>
>> which is new with your patch.
> 
> Sorry to nag, but does anybody have a clue where to go from here? I can
> start digging in the OMAP PM code, but it's all new territory for me.

I did a little playing around with this today and I think that I have figured out why this was not working (see below). Please can you try the following patch? I tried this on top of your series for perf/omap4. 

Paul, FYI. If this works for Will then I can re-base on top of the latest linux-omap and submit to the mailing list.

Also, the above error about the emu_pwrdm is odd too. I noticed that the emu_pwrdm is always in the transitioning state. And when I say always, I mean that even if I check the power domain state while u-boot is running it is in the transitioning state. So even before the kernel starts. 

Cheers
Jon 

>From 9137ff9c1b382232de7443db0b51b7555846fb62 Mon Sep 17 00:00:00 2001
From: Jon Hunter <jon-hunter@ti.com>
Date: Fri, 4 May 2012 16:48:45 -0500
Subject: [PATCH] ARM: OMAP4: Disable auto enable for EMU CLKDM

The flag CLKDM_CAN_HWSUP allows the clock-domain to automatically transition
to the enabled and disabled state. This means that as soon as we force a
software wake-up on the clock domain, the clock domain will be allowed to idle
and put back into the hardware auto state. For the EMU clock domain this is not
what we want. We want to keep the clock domain in the software wakeup state
while the clock domain is being used and put it back in to the hardware auto
state when we have finished using the clock domain.

Signed-off-by: Jon Hunter <jon-hunter@ti.com>
---
 arch/arm/mach-omap2/clockdomains44xx_data.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/clockdomains44xx_data.c b/arch/arm/mach-omap2/clockdomains44xx_data.c
index 9299ac2..dd2cd96 100644
--- a/arch/arm/mach-omap2/clockdomains44xx_data.c
+++ b/arch/arm/mach-omap2/clockdomains44xx_data.c
@@ -390,7 +390,7 @@ static struct clockdomain emu_sys_44xx_clkdm = {
 	.prcm_partition	  = OMAP4430_PRM_PARTITION,
 	.cm_inst	  = OMAP4430_PRM_EMU_CM_INST,
 	.clkdm_offs	  = OMAP4430_PRM_EMU_CM_EMU_CDOFFS,
-	.flags		  = CLKDM_CAN_HWSUP,
+	.flags		  = CLKDM_CAN_FORCE_WAKEUP | CLKDM_CAN_DISABLE_AUTO,
 };
 
 static struct clockdomain l3_dma_44xx_clkdm = {
-- 
1.7.5.4

  parent reply	other threads:[~2012-05-04 22:18 UTC|newest]

Thread overview: 111+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAAO=S0+L2Q1YZC-pfm2Lz8jPooTeHYOMaZbtRgHYFoL_m7rvhA@mail.gmail.com>
     [not found] ` <4F0B182D.7060507@us.ibm.com>
2012-01-09 22:49   ` oprofile and ARM A9 hardware counter Will Deacon
2012-01-09 23:30     ` Ming Lei
2012-01-10  0:46       ` stephane eranian
2012-01-18  4:18         ` Ming Lei
2012-01-18  9:33           ` Ming Lei
2012-01-18 11:39             ` Shilimkar, Santosh
2012-01-18 12:24               ` Ming Lei
2012-01-18 12:33                 ` Shilimkar, Santosh
2012-04-03  9:25                   ` Will Deacon
2012-04-03  9:42                     ` Shilimkar, Santosh
2012-04-03  9:47                       ` Will Deacon
2012-04-03 10:01                         ` Shilimkar, Santosh
2012-04-03 12:34                           ` Will Deacon
2012-04-03 12:41                             ` Shilimkar, Santosh
2012-04-03 14:27                             ` Kevin Hilman
2012-04-03 16:07                               ` Will Deacon
2012-04-03 23:14                                 ` Kevin Hilman
2012-04-03 23:29                                   ` Paul Walmsley
2012-04-04  3:42                                     ` Ming Lei
2012-04-04 11:15                                     ` Will Deacon
2012-04-26 18:07                                       ` Will Deacon
2012-04-30 22:25                                         ` Kevin Hilman
2012-05-07 17:27                                           ` Ming Lei
2012-05-04 22:17                                         ` Jon Hunter [this message]
2012-05-07 17:15                                           ` Kevin Hilman
2012-05-07 19:53                                             ` Jon Hunter
2012-05-07 23:28                                               ` Kevin Hilman
2012-05-08 11:01                                                 ` Cousson, Benoit
2012-05-08 11:23                                                   ` Jean Pihet
2012-05-08 12:37                                                     ` Cousson, Benoit
2012-05-08 13:18                                                       ` Jean Pihet
2012-05-08 14:00                                                         ` Kevin Hilman
2012-05-08 14:03                                                           ` Cousson, Benoit
2012-05-08 16:18                                                             ` Kevin Hilman
2012-05-08 19:51                                                               ` Jon Hunter
2012-05-08 21:28                                                                 ` Kevin Hilman
2012-05-08 22:20                                                                   ` Jon Hunter
2012-05-08 22:12                                                                 ` Ming Lei
2012-05-08 17:31                                                   ` Jon Hunter
2012-05-08 21:22                                                     ` Kevin Hilman
2012-05-08 23:59                                                       ` Jon Hunter
2012-05-09 10:58                                                       ` Cousson, Benoit
2012-05-09 18:04                                                         ` Jon Hunter
2012-05-09 19:28                                                           ` Jon Hunter
2012-05-09 21:45                                                             ` Jon Hunter
2012-05-10  8:44                                                               ` Will Deacon
2012-05-10  9:12                                                                 ` stephane eranian
2012-05-10 18:55                                                                 ` Jon Hunter
2012-05-11 12:25                                                                   ` Will Deacon
2012-05-11 13:47                                                                     ` Jon Hunter
2012-05-11 13:49                                                                       ` Will Deacon
2012-05-11 14:52                                                                         ` Jon Hunter
2012-05-11 15:02                                                                           ` Will Deacon
2012-05-11 16:31                                                                             ` Jon Hunter
2012-05-11 16:38                                                                               ` Will Deacon
2012-05-11 23:51                                                                                 ` Jon Hunter
2012-05-15 13:52                                                                                   ` Will Deacon
2012-05-10 14:12                                                               ` Kevin Hilman
2012-05-10 19:05                                                                 ` Jon Hunter
2012-05-10  6:59                                                         ` Santosh Shilimkar
2012-05-08 21:50                                                 ` Paul Walmsley
2012-04-04  0:00                             ` Paul Walmsley
2012-04-04 11:07                               ` Will Deacon
2012-01-18  9:54           ` stephane eranian
2012-01-18 10:07             ` Ming Lei
2012-01-18 21:58               ` stephane eranian
2012-01-19  1:21                 ` Ming Lei
2012-01-19 11:34                   ` stephane eranian
2012-01-19 12:45                     ` Ming Lei
2012-01-19 12:51                       ` stephane eranian
2012-01-19 12:55                         ` stephane eranian
2012-01-19 13:14                         ` Ming Lei
2012-01-19 13:26                           ` Ming Lei
2012-01-19 13:32                             ` stephane eranian
2012-01-19 13:51                               ` Ming Lei
2012-01-19 17:07                                 ` stephane eranian
2012-01-20 13:47                                   ` stephane eranian
2012-01-21  3:25                                     ` Ming Lei
2012-01-21  9:16                                       ` stephane eranian
2012-01-27 12:13                                         ` Will Deacon
2012-01-27 12:45                                           ` stephane eranian
2012-01-27 12:56                                           ` Måns Rullgård
2012-01-27 13:28                                             ` Will Deacon
2012-01-27 13:32                                               ` stephane eranian
2012-01-27 13:47                                               ` Måns Rullgård
2012-01-27 13:56                                                 ` Will Deacon
2012-01-27 14:05                                                   ` Måns Rullgård
2012-01-27 14:09                                               ` Ming Lei
2012-01-27 15:45                                                 ` stephane eranian
2012-01-27 15:54                                                   ` Will Deacon
2012-01-27 15:57                                                     ` stephane eranian
2012-01-27 16:59                                                       ` Will Deacon
2012-01-27 17:03                                                         ` stephane eranian
2012-01-27 17:10                                                           ` Will Deacon
2012-01-27 17:16                                                             ` stephane eranian
2012-01-29 17:36                                                               ` stephane eranian
2012-01-30  9:40                                                                 ` Ming Lei
2012-01-30 10:24                                                                   ` stephane eranian
2012-01-30 13:43                                                                     ` stephane eranian
2012-01-30 14:49                                                                       ` Ming Lei
2012-01-30 16:02                                                                         ` stephane eranian
2012-01-30 16:08                                                                           ` Måns Rullgård
2012-01-30 17:15                                                                             ` stephane eranian
2012-01-30 17:24                                                                               ` Will Deacon
2012-01-30 17:45                                                                                 ` stephane eranian
2012-01-30 19:14                                                                                   ` Will Deacon
2012-01-30 20:45                                                                                     ` stephane eranian
2012-03-07  2:49                                                     ` Ming Lei
2012-03-07  9:48                                                       ` Will Deacon
2012-01-27 14:06                                           ` Ming Lei
2012-01-18 10:18             ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FA45580.8070802@ti.com \
    --to=jon-hunter@ti.com \
    --cc=b-cousson@ti.com \
    --cc=eranian@gmail.com \
    --cc=khilman@ti.com \
    --cc=lik88888@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=maynardj@us.ibm.com \
    --cc=ming.lei@canonical.com \
    --cc=oprofile-list@lists.sourceforge.net \
    --cc=paul@pwsan.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).