[PATCH] omap-usb-host: include <plat/cpu.h>

[PATCH] omap-usb-host: include <plat/cpu.h>

[Jeff Mahoney]

omap-usb-host calls cpu_is_omap3430, which is defined in plat/cpu.h.

Reported-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
 drivers/mfd/omap-usb-host.c |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -26,6 +26,7 @@
 #include <linux/dma-mapping.h>
 #include <linux/spinlock.h>
 #include <plat/usb.h>
+#include <plat/cpu.h>
 #include <linux/pm_runtime.h>
 
 #define USBHS_DRIVER_NAME	"usbhs_omap"

-- 
Jeff Mahoney
SUSE Labs

Re: [PATCH] omap-usb-host: include <plat/cpu.h>

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

Hi,

On Wed, May 02, 2012 at 10:36:44AM -0400, Jeff Mahoney wrote:
> omap-usb-host calls cpu_is_omap3430, which is defined in plat/cpu.h.
> 
> Reported-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>

this looks right to me, though a driver shouldn't be using cpu_is_***
macros. Still, that patch can come later, this is needed now.

Acked-by: Felipe Balbi <balbi@ti.com>

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] omap-usb-host: include <plat/cpu.h>

[Guillaume Gardet]

Hi,

Le 03/05/2012 09:50, Felipe Balbi a écrit :
> Hi,
>
> On Wed, May 02, 2012 at 10:36:44AM -0400, Jeff Mahoney wrote:
>> omap-usb-host calls cpu_is_omap3430, which is defined in plat/cpu.h.
>>
>> Reported-by: Guillaume GARDET<guillaume.gardet@opensuse.org>
>> Signed-off-by: Jeff Mahoney<jeffm@suse.com>
> this looks right to me, though a driver shouldn't be using cpu_is_***
> macros. Still, that patch can come later, this is needed now.
>
> Acked-by: Felipe Balbi<balbi@ti.com>
>

It seems it have been added in mainline:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=13176a89e1c4a0011bd9f576730b0338ecb619ff

Guillaume

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html