From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Cousson, Benoit" Subject: Re: [PATCH-V6 0/3] ARM: OMAP: Make OMAP clocksource source selection runtime Date: Mon, 7 May 2012 14:39:55 +0200 Message-ID: <4FA7C29B.2000605@ti.com> References: <1335967014-11937-1-git-send-email-hvaibhav@ti.com> <4FA19162.5040102@ti.com> <79CD15C6BA57404B839C016229A409A83EA11F12@DBDE01.ent.ti.com> <4FA2CC3D.8000804@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:57051 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756342Ab2EGMkF (ORCPT ); Mon, 7 May 2012 08:40:05 -0400 In-Reply-To: <4FA2CC3D.8000804@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Jon Hunter Cc: "Hiremath, Vaibhav" , "linux-omap@vger.kernel.org" , "Hilman, Kevin" , "paul@pwsan.com" , "tony@atomide.com" , "Shilimkar, Santosh" , "linux-arm-kernel@lists.infradead.org" On 5/3/2012 8:19 PM, Jon Hunter wrote: > Hi Vaibhav, > > On 05/03/2012 12:07 AM, Hiremath, Vaibhav wrote: >> On Thu, May 03, 2012 at 01:26:18, Hunter, Jon wrote: >>> Hi Vaibhav, >>> >>> On 05/02/2012 08:56 AM, Vaibhav Hiremath wrote: >>>> Current OMAP code supports couple of clocksource options based >>>> on compilation flag (CONFIG_OMAP_32K_TIMER). The 32KHz sync-timer >>>> and a gptimer which can run on 32KHz or system clock (e.g 38.4 MHz) >>>> >>>> This patch series cleans up the existing 32k-sync timer implementation, >>>> movind SoC init code to respective files (mach-omap1/timer32k.c and >>>> mach-omap2/timer.c) and uses kernel parameter to override the default >>>> clocksource of "counter_32k", also in order to support some OMAP based >>>> derivative SoCs like AM33XX which doesn't have 32K sync-timer hardware IP, >>>> adds hwmod lookup for omap2+ devices, and if lookup fails then >>>> fall back to gp-timer. >>>> >>>> if(use_gptimer_clksrc == true) >>>> gptimer clocksource init; >>>> else if (counter_32 init == false) >>>> /* Fallback to gptimer */ >>>> gptimer clocksource init(; >>>> >>>> With this, we should be able to support multi-omap boot >>>> including devices with/without 32k-sync timer. >>>> >>>> This patch-series has been boot tested on AM37xEVM platform, it >>>> would be helpful if somebody help me to validate it on OMAP1/2 >>>> platforms. >>>> >>>> The patches are also available at (based on linux-omap/master) - >>>> https://github.com/hvaibhav/am335x-linux 32ksync-timer-cleanup >>> >>> I was testing on OMAP4 and I found that the gptimer was always being set by default. I noticed that currently the HWMOD for counter_32k on OMAP4 is commented and hence was not being found. Please can you include the following with your series? >>> >> >> The 32kcounter hwmod entry is already enabled in linux-omap/master branch. >> >> Your baseline looks pretty old to me, are you not using linux-omap/master? > > Ha! My "old" baseline is the latest mainline kernel ;-) > > I guess this is a bit out-dated in terms of omap now. Sorry I missed > that fact your patches were on top of the omap kernel in the changelog. Yeah, in fact Paul submitted a big series to clean / re-organize and add missing hwmod for 3.5. So any change on hwmod should be done on top of Paul's branch. Regards, Benoit