From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [RFC PATCH v2 09/11] ARM: DT: Add support to system control module for OMAP4 Date: Mon, 18 Jun 2012 16:13:46 +0400 Message-ID: <4FDF1B7A.6010608@mvista.com> References: <1337934361-1606-1-git-send-email-eduardo.valentin@ti.com> <4FDF11D6.6050205@dev.rtsoft.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:53332 "EHLO mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750696Ab2FRMOd (ORCPT ); Mon, 18 Jun 2012 08:14:33 -0400 Received: by lahd3 with SMTP id d3so3450128lah.19 for ; Mon, 18 Jun 2012 05:14:32 -0700 (PDT) In-Reply-To: <4FDF11D6.6050205@dev.rtsoft.ru> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Konstantin Baydarov Cc: b-cousson@ti.com, kishon@ti.com, santosh.shilimkar@ti.com, tony@atomide.com, paul@pwsan.com, amit.kucheria@linaro.org, Eduardo Valentin , balbi@ti.com, linux-pm@lists.linux-foundation.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, amit.kachhap@linaro.org Hello. On 18-06-2012 15:32, Konstantin Baydarov wrote: > This patch adds device tree entries on OMAP4 based boards > for System Control Module (SCM). > TODO: > The IOMEM windows of ctrl_module_core, bandgap, usbphy overlap, so > probably only specific registers should be specified in dts for > bandgap and usb phy entries. > Signed-off-by: Konstantin Baydarov > Signed-off-by: Eduardo Valentin > --- > arch/arm/boot/dts/omap4.dtsi | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > Index: linux-2.6/arch/arm/boot/dts/omap4.dtsi > =================================================================== > --- linux-2.6.orig/arch/arm/boot/dts/omap4.dtsi > +++ linux-2.6/arch/arm/boot/dts/omap4.dtsi > @@ -272,5 +272,22 @@ > ti,hwmods = "mmc5"; > ti,needs-special-reset; > }; > + > + ctrl_module_core: ctrl_module_core@4a002000 { > + compatible = "ti,omap4-control"; > + #address-cells =<1>; > + #size-cells =<1>; > + ranges; > + ti,hwmods = "ctrl_module_core"; > + reg =<0x4a002000 0x1000>; > + bandgap@4a002000 { > + compatible = "ti,omap4-bandgap"; > + reg =<0x4a002000 0x1000>; > + }; > + usb@4a002000 { > + compatible = "ti,omap4-usb-phy"; > + reg =<0x4a002000 0x1000>; Two devices at the same address? Also, shouldn't values in the "reg" property be relative to the value in the parent's "reg" property? Are they needed at all here? WBR, Sergei