From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Zumeng Chen <zumeng.chen@windriver.com>
Cc: jon-hunter@ti.com, mike@compulab.co.il,
linux-omap@vger.kernel.org, tony@atomide.com, khilman@ti.com,
hvaibhav@ti.com, linux-arm-kernel@lists.infradead.org,
ajay.gupta@ti.com
Subject: Re: [PATCH 3/5] ARM: omap3evm: enable VBUS switch for EHCI tranceiver
Date: Wed, 20 Jun 2012 16:05:44 +0400 [thread overview]
Message-ID: <4FE1BC98.7050607@mvista.com> (raw)
In-Reply-To: <1340183693-3195-4-git-send-email-zumeng.chen@windriver.com>
Hello.
On 20-06-2012 13:14, Zumeng Chen wrote:
> This was chosen by following the trace on the schematic from component U131
> and U134 to the CPEN pin on the USB3320 device.
> TWL4030.GPIO2-...->(T2_GPIO2_3V3)U131-..>nUSB2_EN-..>U134-..>EXP_nUSB2_1V8
> which starts EHCI tranceiver USB3320.
> This will set TWL4030.GPIO2 as output pin to drive EHCI tranceiver.
> Signed-off-by: Zumeng Chen<zumeng.chen@windriver.com>
> ---
> arch/arm/mach-omap2/board-omap3evm.c | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
> diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c
> index 1bfbe42..02d8047 100644
> --- a/arch/arm/mach-omap2/board-omap3evm.c
> +++ b/arch/arm/mach-omap2/board-omap3evm.c
> @@ -360,6 +360,15 @@ static int omap3evm_twl_gpio_setup(struct device *dev,
>
> platform_device_register(&leds_gpio);
>
> + /* Enable VBUS switch by setting TWL4030.GPIO2DIR as output
> + * for starting USB tranceiver
> + */
> + if (get_omap3_evm_rev()>= OMAP3EVM_BOARD_GEN_2) {
> + u8 val;
Empty line after declaration block wouldn't hurt...
> + twl_i2c_read_u8(TWL4030_MODULE_GPIO,&val, REG_GPIODATADIR1);
> + val |= 0x04; /* TWL4030.GPIO2DIR BIT at GPIODATADIR1(0x9B) */
> + twl_i2c_write_u8(TWL4030_MODULE_GPIO, val, REG_GPIODATADIR1);
> + }
> return 0;
> }
WBR, Sergei
next prev parent reply other threads:[~2012-06-20 12:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 9:14 [PATCH v3 0/5] ARM OMAP3530evm misc fixes Zumeng Chen
2012-06-20 9:14 ` [PATCH 1/5] ARM: OMAP3EVM: Add NAND flash definition Zumeng Chen
2012-06-20 9:14 ` [PATCH 2/5] ARM: OMAP3EVM: Adding USB internal LDOs board file Zumeng Chen
2012-06-20 9:14 ` [PATCH 3/5] ARM: omap3evm: enable VBUS switch for EHCI tranceiver Zumeng Chen
2012-06-20 12:05 ` Sergei Shtylyov [this message]
2012-06-21 1:03 ` Zumeng Chen
2012-07-06 8:41 ` Tony Lindgren
2012-07-08 7:50 ` Zumeng Chen
2012-06-20 9:14 ` [PATCH 4/5] ARM: OMAP3EVM: cosmetic fixes for parent clk set Zumeng Chen
2012-06-20 16:00 ` Jon Hunter
2012-06-21 1:05 ` Zumeng Chen
2012-07-06 8:38 ` Tony Lindgren
2012-06-20 9:14 ` [PATCH 5/5] ARM: OMAP3530evm: set pendown_state and debounce time for ads7846 Zumeng Chen
-- strict thread matches above, loose matches on Subject: below --
2012-06-11 14:00 [PATCH 0/5] OMAP3530evm misc fixes for linux-omap Zumeng Chen
2012-06-11 14:00 ` [PATCH 3/5] ARM: omap3evm: enable VBUS switch for EHCI tranceiver Zumeng Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE1BC98.7050607@mvista.com \
--to=sshtylyov@mvista.com \
--cc=ajay.gupta@ti.com \
--cc=hvaibhav@ti.com \
--cc=jon-hunter@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mike@compulab.co.il \
--cc=tony@atomide.com \
--cc=zumeng.chen@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).