Re: [PATCH RESEND] ARM: OMAP4: hwmod data: add HWMOD_SWSUP_SIDLE to dss_hdmi to data

["Cousson, Benoit" <b-cousson@ti.com>]

Hi Ricardo,

Thanks for the update.

On 6/21/2012 1:10 AM, Ricardo Neri wrote:
> As per the OMAP4 documentation, audio over HDMI should be transmitted in
> no-idle mode. This patch adds the HWMOD_SWSUP_SIDLE so that omap_hwmode uses
> no-idle/force-idle settings instead of smart-idle mode.
>
> This is required as the DSS interface clock is used as functional clock
> for the HDMI wrapper audio FIFO. If no-idle mode is not used, audio could
> be choppy, have bad quality or not be audible at all.
>
> Signed-off-by: Ricardo Neri <ricardo.neri@ti.com>

Acked-by: Benoit Cousson <b-cousson@ti.com>


Paul,
Will you take it as part of your fixes series for 3.5-rc?

Regards,
Benoit

> ---
>   arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> index 950454a..0cd6ee1 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> @@ -865,6 +865,11 @@ static struct omap_hwmod omap44xx_dss_hdmi_hwmod = {
>   	},
>   	.opt_clks	= dss_hdmi_opt_clks,
>   	.opt_clks_cnt	= ARRAY_SIZE(dss_hdmi_opt_clks),
> +	/*
> +	 * HDMI audio requires to use no-idle mode. Hence,
> +	 * set idle mode by software.
> +	 */
> +	.flags          = HWMOD_SWSUP_SIDLE,
>   };
>
>   /*
>