From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shubhrajyoti Subject: Re: [PATCHv8 03/13] I2C: OMAP: Remove reset at init Date: Thu, 21 Jun 2012 15:00:59 +0530 Message-ID: <4FE2E9D3.5060304@ti.com> References: <1340029828-20751-1-git-send-email-shubhrajyoti@ti.com> <1340029828-20751-4-git-send-email-shubhrajyoti@ti.com> <20120620102905.GC12766@atomide.com> <4FE2C750.3020803@ti.com> <20120621071959.GV12766@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from na3sys009aog117.obsmtp.com ([74.125.149.242]:38337 "EHLO na3sys009aog117.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759157Ab2FUJbS (ORCPT ); Thu, 21 Jun 2012 05:31:18 -0400 Received: by obbta17 with SMTP id ta17so721346obb.36 for ; Thu, 21 Jun 2012 02:31:17 -0700 (PDT) In-Reply-To: <20120621071959.GV12766@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ben-linux@fluff.org, w.sang@pengutronix.de On Thursday 21 June 2012 12:50 PM, Tony Lindgren wrote: > * Shubhrajyoti [120621 00:08]: >> On Wednesday 20 June 2012 03:59 PM, Tony Lindgren wrote: >>> See the comments regarding driver specific resets in hwmod code. >> you mean omap_hwmod.c >>> The way to set this up is to have a shared inline function in >>> i2c-omap.h that both the driver and hwmod code can use. >> hwmod reset function uses oh (omap_hwmod). >> >> How could the driver also pass oh ? >> Could we keep a local copy in driver data? >>> Eventually hwmod code will do the reset only in late initcall >>> if no driver is loaded for the device in question. > There's no need for the driver to know anything about oh. > The driver just needs to know the iobase. I will rework to make the hwmod and driver use the same function. In the meanwhile I will send a minimal/ remaining cleanups/ fixes so that it might get some time to bake in the next branch. > > Tony