From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajendra Nayak Subject: Re: [PATCH 02/11] mmc: omap: add clk_prepare and clk_unprepare Date: Mon, 25 Jun 2012 12:43:19 +0530 Message-ID: <4FE80F8F.6050404@ti.com> References: <1340372890-10091-1-git-send-email-rnayak@ti.com> <1340372890-10091-3-git-send-email-rnayak@ti.com> <4FE7F636.7040803@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org To: Paul Walmsley Cc: "S, Venkatraman" , mturquette@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Chris Ball , Balaji T K , linux-mmc@vger.kernel.org List-Id: linux-omap@vger.kernel.org On Monday 25 June 2012 11:48 AM, Paul Walmsley wrote: > On Mon, 25 Jun 2012, Rajendra Nayak wrote: > >> On Saturday 23 June 2012 12:04 AM, Paul Walmsley wrote: >>> On Fri, 22 Jun 2012, S, Venkatraman wrote: >>> >>>> On Fri, Jun 22, 2012 at 7:18 PM, Rajendra Nayak wrote: >>>>> In preparation of OMAP moving to Common Clk Framework(CCF) add >>>>> clk_prepare() >>>>> and clk_unprepare() for the mmc and hsmmc clocks as part of the drivers >>>>> probe() and remove() routines. >>>>> >>>>> Signed-off-by: Rajendra Nayak >>>>> Cc: Chris Ball >>>>> Cc: Balaji T K >>>>> Cc: >>>> >>>> Rajendra, >>>> Can this be applied independently, or does this patch have a >>>> dependency on other patches in the series ? >>> >>> A better way to handle this one would be to convert the driver to runtime >>> PM. That needs to be done anyway. >> >> Well, mmc driver is already using runtime PM. But it still using clock >> apis' to deal with some optional debounce clock needed only on 2430. > > drivers/mmc/host/omap.c, which is what this patch changes, has not yet > been converted to use runtime PM in mainline. Venkat/Balaji, Any plans of converting this driver to use runtime pm? > > This is a driver for the MSDI IP block which is not available on 2430. Sorry, I meant to say the debounce clock in omap_hsmmc.c was used only on 2430. I seemed to have overlooked the fclk/iclk in drivers/mmc /host/omap.c completely. That one seems to be for the controller in 2420 (atlest, and maybe some other older OMAPs). > > - Paul