From: Rajendra Nayak <rnayak@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: mturquette@ti.com, mturquette@linaro.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 3/3] ARM: omap: clk: Remove all direct dereferencing of struct clk
Date: Mon, 02 Jul 2012 15:52:32 +0530 [thread overview]
Message-ID: <4FF17668.2070306@ti.com> (raw)
In-Reply-To: <4FF1705B.6070404@ti.com>
>>
>> In the case of the quoted string warnings, please go ahead and
>> concatenate those strings while you are there. That needs to be done
>> anyway.
>
> Ok, will do. I was able to fix all but one hard to fix CHECK for this
> patch..
>
> ---
> CHECK: Alignment should match open parenthesis
> #608: FILE: arch/arm/mach-omap2/dpll3xxx.c:455:
> + if (__clk_get_rate(dd->clk_bypass) == rate &&
> (clk->dpll_data->modes & (1 << DPLL_LOW_POWER_BYPASS))) {
>
> total: 0 errors, 0 warnings, 1 checks, 608 lines checked
>
> 0003-ARM-omap-clk-Remove-all-direct-dereferencing-of-stru.patch has
> style problems, please review.
>
> If any of these errors are false positives, please report
> ---
>
> I could not find anything wrong with the alignment, but checkpatch
> keeps complaining. It complains for the original code too.
> Might be a checkpatch bug? Or do you really see anything wrong in
> the alignment?
Does seem like a checkpatch issue to me, checkpatch -f on the file
after applying the patch does not throw me the 'CHECK' anymore.
Will ignore this for now and respin my v3 and report this to the
checkpatch folks.
prev parent reply other threads:[~2012-07-02 10:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 8:48 [PATCH v2 0/3] Prepare for OMAP2+ movement to Common Clk Rajendra Nayak
2012-06-27 8:48 ` [PATCH v2 1/3] ARM: omap: clk: add clk_prepare and clk_unprepare Rajendra Nayak
2012-06-29 20:19 ` Paul Walmsley
2012-06-29 20:20 ` Paul Walmsley
2012-07-02 9:47 ` Rajendra Nayak
2012-06-27 8:48 ` [PATCH v2 2/3] ARM: omap: hwmod: get rid of all omap_clk_get_by_name usage Rajendra Nayak
2012-06-29 20:22 ` Paul Walmsley
2012-06-27 8:48 ` [PATCH v2 3/3] ARM: omap: clk: Remove all direct dereferencing of struct clk Rajendra Nayak
2012-06-29 20:23 ` Paul Walmsley
2012-07-02 9:56 ` Rajendra Nayak
2012-07-02 10:22 ` Rajendra Nayak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF17668.2070306@ti.com \
--to=rnayak@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=mturquette@ti.com \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).