From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shubhrajyoti Subject: Re: [PATCH v2 00/17] Big OMAP I2C Cleanup Date: Mon, 02 Jul 2012 17:23:21 +0530 Message-ID: <4FF18BB1.3050503@ti.com> References: <1339691067-919-1-git-send-email-balbi@ti.com> <20120614175950.GE14419@pengutronix.de> <4FE99432.8030300@ti.com> <20120702113712.GB2730@arwen.pp.htv.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from na3sys009aog125.obsmtp.com ([74.125.149.153]:49680 "EHLO na3sys009aog125.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750834Ab2GBLx3 (ORCPT ); Mon, 2 Jul 2012 07:53:29 -0400 Received: by yenl8 with SMTP id l8so4723650yen.13 for ; Mon, 02 Jul 2012 04:53:27 -0700 (PDT) In-Reply-To: <20120702113712.GB2730@arwen.pp.htv.fi> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: balbi@ti.com Cc: Wolfram Sang , ben-linux@fluff.org, Tony Lindgren , Santosh Shilimkar , Russell King , Linux OMAP Mailing List , Linux ARM Kernel Mailing List , Linux Kernel Mailing List On Monday 02 July 2012 05:07 PM, Felipe Balbi wrote: > Hi, > > On Tue, Jun 26, 2012 at 04:21:30PM +0530, Shubhrajyoti wrote: >> On Thursday 14 June 2012 11:29 PM, Wolfram Sang wrote: >>>> - removed dev_err() which was introduced on patch 09/17 >>> To prevent the list being flooded, I would appreciate if you could wait >>> a few days to collect reviews before resending. It will take some time >>> until I pick this series anyhow, because I want people to have time to >>> donate Tested-by tags. >> Felipe thats a good cleanup. >> The series look good to me. >> >> Also draining interrupt I had some queries. >> Looks good to me. >> >> I have tested it after rebasing. > rebasing on top of what ? On top of embedded i2c branch of Wolfram. > You should resend the series so that I know > what changes you have made to my original patchset. Make sure to list on > the commit log what where the changes you made, so that it looks > something like this commit below where I changed commit log a bit: Will do that. Thanks, > | commit 3daf74d78dfcd552445c35f1b82a271ca305ceb9 > | Author: Pratyush Anand > | Date: Sat Jun 23 02:23:08 2012 +0530 > | > | usb: dwc3: remove WARN_ON from dwc_stop_active_transfer > | > | Now we are sure that, if res_trans_idx is zero, then endpoint has been > | stopped. So it's safe to just return if endpoint is already stopped. No > | need to generate warning anymore. > | > | While doing so, it's better to return when res_trans_idx is zero and > | decrease one level of indentation. > | > | Signed-off-by: Pratyush Anand > | > | [ balbi@ti.com: slightly changed commit log ] > | > | Signed-off-by: Felipe Balbi > >> Tested-by : Shubhrajyoti > since you will send, you should, probably, add your Signed-off-by, > instead of Tested-by. dunno. >